Skip to content

multipart/form-data in V2 is not properly handled #747

Closed

Description

@justinyoo

Hi, Team.

I found that there had been an issue #509 and fix #511 with regards to the file upload through the multipart/form-data content type. However, when I checked the source code, it only partially covers the cases.

  1. According to the OpenAPI v3.0.1 spec, file input/output can be the schema type/format of string/binary or string/base64. However, the codebase only looks after the string/binary pair.

    if (paramSchema.Type == "string" && paramSchema.Format == "binary") {
    paramSchema.Type = "file";
    paramSchema.Format = null;
    }

  2. According to the 3.0.1 spec, it's valid to have schema reference (the $ref value) under the requestBody/content/<media-type>/schema object instead of the properties object. However, the current codebase only looks after the properties object.

    foreach (var property in RequestBody.Content.First().Value.Schema.Properties)

Therefore, these two issues need to be resolved for proper V3 ➡️ V2 conversion. The Azure Functions OpenAPI extension has addressed this issue, which relies on this OpenAPI.NET package.

Activity

  1. darrelmiller commented on Feb 22, 2022

    @darrelmiller
    Member

    Thanks for reporting this. We will investigate.

  2. added
    priority:p2Medium. Generally has a work-around and a smaller sub-set of customers is affected. SLA <=30 days
    and removed on Mar 1, 2022
  3. added this to the 1.4 milestone on Mar 29, 2022
  4. darrelmiller commented on Aug 23, 2022

    @darrelmiller
    Member

    The first option can be resolved with this update.

     if (paramSchema.Type == "string" && (paramSchema.Format == "binary" || paramSchema.Format == "base64") ) { 
         paramSchema.Type = "file"; 
         paramSchema.Format = null; 
     } 
    

    The second item shouldn't actually be an issue as $ref should get resolved during reference resolution after reading the file in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

priority:p2Medium. Generally has a work-around and a smaller sub-set of customers is affected. SLA <=30 daystype:bugA broken experience

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions