You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
OpenAPI.NET 1.2.0 is not backwards compatible with 1.1.x #487
If another project references the old version, it cannot find the constructor since its signature has changed. It would have been better to add a new constructor or increase the major version number of the package (if you adhere to semantic versioning). At the very least, breaking api changes should be documented in the release notes.
Reacted by Szymek, Fabian Niederer, David Cumps and freeranger
Activity
CumpsD commentedon Jun 22, 2020
This just bit me
System.MissingMethodException: Method not found: 'Void Microsoft.OpenApi.Any.OpenApiString..ctor(System.String)'.CumpsD commentedon Jun 24, 2020
Added a PR: #489
Would be nice to merge it, bump your version and unlist 1.2.0
CumpsD commentedon Jun 24, 2020
Darrel (@darrelmiller) any chance for your input on this one please?
darrelmiller commentedon Jun 24, 2020
Ugh. Apparently optional parameters have source backward compatibility but not binary backward compatibility.
CumpsD commentedon Jun 24, 2020
Yep :) Compiler magic...
Merge pull request #489 from CumpsD/patch-1
hasancemcerit commentedon Jun 24, 2020
With 1.2.1, the previous
OpenApiStringerror just got transformed intoMethod not found: 'Void Microsoft.OpenApi.Writers.OpenApiJsonWriter..ctor(System.IO.TextWriter)'.🤔
CumpsD commentedon Jun 24, 2020
Hasan (@hasancemcerit) PR ongoing to fix it: #492
CumpsD commentedon Jun 25, 2020
It's fixed. 1.2.2 has no breaking changes, and the others got delisted.
Darrel (@darrelmiller) This can probably be closed now :)
Prevent breaking change on optional parameter #487
darrelmiller commentedon Jul 2, 2020
David Cumps (@CumpsD) Thank you for your help with this.