You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add the remaining unit tests for V2 and V3 deserializers #115
#109 (through PR #113) already sets the structure of how the tests can be written for both versions of the deserializers. The remaining job is actually going ahead and write the tests for each and every object.
PerthCharern Any reason why we are changing from using embedded resources to using file paths for test input files? My experience is that embedded files are much more reliable than depending on a file path that is relative to the working directory of the test runner. Now the CI scripts that run the tests have to worry about making sure the input files are in the right place.
Darrel (@darrelmiller) Not a strong reason, but I found the syntax for embedded files a bit awkward. Instead of a path, it uses the period notation. I'm not sure if most people are familiar with using embedded files this way, but I might be completely wrong on this.
I'm not sure what you meant by "Now the CI scripts that run the tests have to worry about making sure the input files are in the right place." Aren't this handled by the way we structure the files in the code base?
Activity
darrelmiller commentedon Dec 11, 2017
PerthCharern Any reason why we are changing from using embedded resources to using file paths for test input files? My experience is that embedded files are much more reliable than depending on a file path that is relative to the working directory of the test runner. Now the CI scripts that run the tests have to worry about making sure the input files are in the right place.
PerthCharern commentedon Dec 13, 2017
Darrel (@darrelmiller) Not a strong reason, but I found the syntax for embedded files a bit awkward. Instead of a path, it uses the period notation. I'm not sure if most people are familiar with using embedded files this way, but I might be completely wrong on this.
I'm not sure what you meant by "Now the CI scripts that run the tests have to worry about making sure the input files are in the right place." Aren't this handled by the way we structure the files in the code base?
PerthCharern commentedon Dec 15, 2017
I understand the concerns now. Let's track this embedded file problem in a separate issue.