-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Manage AML environments from conda YAML files #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sudivate
merged 38 commits into
microsoft:master
from
algattik:algattik/conda-envs-aml-env
Feb 4, 2020
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
f69a2ca
Merge pull request #2 from microsoft/master
algattik 7b370c1
Merge remote-tracking branch 'upstream/master'
algattik 3ab3230
Merge branch 'master' of https://github.com/microsoft/MLOpsPython
algattik c840623
.
algattik c2b953f
.
algattik bceeba6
Update code_test.py
algattik 897b7d4
.
algattik e304fd2
Update Dockerfile
algattik 41c2499
Do not use conda-merge
algattik 963b36a
Merge remote-tracking branch 'upstream/master' into algattik/conda-envs
algattik 921b65f
PR review fixes
algattik 2956ada
Merge remote-tracking branch 'upstream/master'
algattik b05c3b7
Update Dockerfile
algattik dd04d4b
Merge branch 'algattik/conda-envs' into algattik/conda-envs-aml-env
algattik e312ae6
.
algattik 7124f5c
Merge branch 'master' into algattik/conda-envs
algattik 23d48ce
Merge branch 'algattik/conda-envs' into algattik/conda-envs-aml-env
algattik 4b9323f
Update deploy_web_service.py
algattik a12bcb2
Update deploy_web_service.py
algattik 732761d
Merge remote-tracking branch 'upstream/master' into algattik/conda-en…
algattik 1cc78b7
Merge remote-tracking branch 'upstream/master' into algattik/conda-envs
algattik 5f81ea1
PR review fixes
algattik 3b6974b
PR review fixes
algattik de72bde
PR review fixes
algattik 568bdee
Update training_dependencies.yml
algattik b719003
Merge branch 'algattik/conda-envs' into algattik/conda-envs-aml-env
algattik 1ddc19e
Linting fixes
algattik 08509c8
Merge remote-tracking branch 'upstream/master' into algattik/conda-en…
algattik 2fa64b8
Fixed merge
algattik a0052dd
Update code_test.py
algattik 2e1192c
Merge branch 'master' of https://github.com/algattik/MLOpsPython
algattik f0a5900
Merge branch 'master' into algattik/conda-envs-aml-env
algattik a80e64a
Simplified environment management, restored deploy task
algattik 2214ad0
Simplified environment management, restored deploy task
algattik 15c7cad
Merge branch 'master' into algattik/conda-envs-aml-env
algattik d4a589a
Fixed doc for new file path
algattik fe35f83
Added comments
algattik 85238c3
Merge branch 'master' into algattik/conda-envs-aml-env
sudivate File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| { | ||
| "name": "diabetes_regression_sklearn", | ||
| "version": null, | ||
| "environmentVariables": { | ||
| "EXAMPLE_ENV_VAR": "EXAMPLE_VALUE" | ||
| }, | ||
| "python": { | ||
| "userManagedDependencies": false, | ||
| "interpreterPath": "python", | ||
| "condaDependenciesFile": null, | ||
| "baseCondaEnvironment": null | ||
| }, | ||
| "docker": { | ||
| "enabled": true, | ||
| "baseImage": "mcr.microsoft.com/azureml/base:intelmpi2018.3-ubuntu16.04", | ||
| "baseDockerfile": null, | ||
| "sharedVolumes": true, | ||
| "shmSize": "2g", | ||
| "arguments": [], | ||
| "baseImageRegistry": { | ||
| "address": null, | ||
| "username": null, | ||
| "password": null | ||
| } | ||
| }, | ||
| "spark": { | ||
| "repositories": [], | ||
| "packages": [], | ||
| "precachePackages": true | ||
| }, | ||
| "databricks": { | ||
| "mavenLibraries": [], | ||
| "pypiLibraries": [], | ||
| "rcranLibraries": [], | ||
| "jarLibraries": [], | ||
| "eggLibraries": [] | ||
| }, | ||
| "inferencingStackVersion": null | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # Details about the Conda environment file format: | ||
| # https://conda.io/docs/using/envs.html#create-environment-file-by-hand | ||
|
|
||
| name: diabetes_regression_sklearn | ||
|
|
||
| dependencies: | ||
|
|
||
| # The python interpreter version. | ||
| - python=3.7.5 | ||
|
|
||
| # Required by azureml-defaults, installed separately through Conda to | ||
| # get a prebuilt version and not require build tools for the install. | ||
| - psutil=5.6 #latest | ||
|
|
||
| - numpy=1.18.1 | ||
| - pandas=1.0.0 | ||
| - scikit-learn=0.22.1 | ||
| #- r-essentials | ||
| #- tensorflow | ||
| #- keras | ||
|
|
||
| - pip=20.0.2 | ||
| - pip: | ||
|
|
||
| # Dependencies for training environment. | ||
|
|
||
| - azureml-core==1.0.79 | ||
|
|
||
| # Dependencies for scoring environment. | ||
|
|
||
| # You must list azureml-defaults as a pip dependency | ||
| - azureml-defaults==1.0.79 | ||
| - inference-schema[numpy-support]==1.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| --- | ||
| computeType: ACI | ||
| containerResourceRequirements: | ||
| cpu: 1 | ||
| memoryInGB: 4 | ||
| computeType: ACI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this file used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Environment.load_from_directory(). Added comment to script for clarity fe35f83
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
azureml_environment.json is not pointing to any conda specification file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the file as generated by
az ml environment scaffold.I assume your concern is about the
nullvalues in this section of the file:If you look at the AML SDK source code, load_from_directory() actually fills the conda_dependencies from a file named
conda_dependencies.ymlis one exists in the passed directory:I've tested that things works as expected, as when I uncomment
r-essentialsfrom the conda file and runml_service/pipelines/diabetes_regression_build_train_pipeline_with_r.py, training succeeds as shown by R output in the logs.