Skip to content

Upgrade to Gradle 9.3.0#4604

Open
Copilot wants to merge 10 commits intomainfrom
copilot/upgrade-to-gradle-9
Open

Upgrade to Gradle 9.3.0#4604
Copilot wants to merge 10 commits intomainfrom
copilot/upgrade-to-gradle-9

Conversation

Copy link
Contributor

Copilot AI commented Jan 28, 2026 •
edited
Loading

Gradle 9 removed LenientConfiguration.getFiles() API used by Spring Boot 2.x plugin. Spring Boot 3.x requires Java 17+, incompatible with Java 8 smoke test containers.

Changes

Gradle updates

  • Wrapper: 8.14.3 → 9.3.0
  • protobuf-gradle-plugin: 0.8.19 → 0.9.6

Smoke test JAR packaging

Replaced Spring Boot plugin with Shadow plugin in ai.smoke-test-jar.gradle.kts:

tasks.named<ShadowJar>("shadowJar") {
  mergeServiceFiles()
  
  transform(PropertiesFileTransformer::class.java) {
    paths = listOf("META-INF/spring.factories")
    mergeStrategy = "append"
  }
  
  manifest {
    attributes["Main-Class"] = project.findProperty("mainClassName") 
      ?: "com.microsoft.applicationinsights.smoketestapp.SpringBootApp"
  }
}

tasks.named<Jar>("jar") {
  enabled = false  // Prevent overwriting shadowJar output
}

Critical: Shadow's append() method concatenates files creating duplicate property keys. Spring Boot reads only first occurrence:

# Broken - duplicate keys
org.springframework.boot.autoconfigure.EnableAutoConfiguration=ActuatorConfigs...
org.springframework.boot.autoconfigure.EnableAutoConfiguration=WebMvcConfigs...

# Fixed - merged values  
org.springframework.boot.autoconfigure.EnableAutoConfiguration=ActuatorConfigs...,WebMvcConfigs...

PropertiesFileTransformer merges duplicate keys into comma-separated values, enabling all auto-configurations (ServletWebServerFactory, WebMvcMetricsAutoConfiguration, etc.).

App-specific fixes

  • JettyNativeHandler, ReadOnly: Custom main class via ext.set("mainClassName", "...")
  • DiagnosticExtension: MockExtension → compileOnly (prevents classloader conflict when extension loaded separately as agent extension)
  • NonDaemonThreads: Added spring-boot-loader dependency (TestController requires JarLauncher class to locate JAR)
Original prompt

Upgrade the project to Gradle 9

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@xiang17
Upgrade to Gradle 9.3.0
03b4571 
Co-authored-by: xiang17 <9310587+xiang17@users.noreply.github.com>
Copilot AI changed the title [WIP] Upgrade project to Gradle 9 Upgrade to Gradle 9.3.0 Jan 28, 2026
Copilot AI requested a review from xiang17 January 28, 2026 08:28
Copilot AI and others added 2 commits January 28, 2026 18:32
@xiang17
Fix smoke test failures by replacing Spring Boot plugin with Shadow
33d9e32 
Co-authored-by: xiang17 <9310587+xiang17@users.noreply.github.com>
@xiang17
Make main class configurable for smoke test apps
92219f8 
Co-authored-by: xiang17 <9310587+xiang17@users.noreply.github.com>
Copilot AI changed the title Upgrade to Gradle 9.3.0 Upgrade to Gradle 9 and fix smoke test Java 8 compatibility Jan 28, 2026
@xiang17
Fix missing Main-Class manifest attribute in smoke test JARs
03f6a94 
Co-authored-by: xiang17 <9310587+xiang17@users.noreply.github.com>
Copilot AI changed the title Upgrade to Gradle 9 and fix smoke test Java 8 compatibility Fix smoke test JARs missing Main-Class manifest attribute Jan 28, 2026
@xiang17
Fix Spring Boot auto-configuration by appending spring.factories
d97d564 
Co-authored-by: xiang17 <9310587+xiang17@users.noreply.github.com>
Copilot AI changed the title Fix smoke test JARs missing Main-Class manifest attribute Upgrade to Gradle 9 and fix smoke test JAR packaging Jan 28, 2026
@xiang17
Fix JavaProfiler test by changing MockExtension to compileOnly depend…
078b8bd 
…ency

Co-authored-by: xiang17 <9310587+xiang17@users.noreply.github.com>
@xiang17
Fix spring.factories merging using PropertiesFileTransformer
93ffe8d 
Co-authored-by: xiang17 <9310587+xiang17@users.noreply.github.com>
Copilot AI changed the title Upgrade to Gradle 9 and fix smoke test JAR packaging Upgrade to Gradle 9.3.0 Feb 5, 2026
@xiang17
Add spring-boot-loader and fix exception handling in NonDaemonThreads
d6d659c 
Co-authored-by: xiang17 <9310587+xiang17@users.noreply.github.com>
Copilot AI changed the title Upgrade to Gradle 9.3.0 Upgrade to Gradle 9.3.0 and migrate smoke tests from Spring Boot to Shadow plugin Feb 5, 2026
@xiang17
Revert try-catch that circumvented NonDaemonThreads test intent
a0b3fb0 
Co-authored-by: xiang17 <9310587+xiang17@users.noreply.github.com>
Copilot AI changed the title Upgrade to Gradle 9.3.0 and migrate smoke tests from Spring Boot to Shadow plugin Upgrade to Gradle 9.3.0 Feb 5, 2026
@xiang17 xiang17 marked this pull request as ready for review February 6, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiang17 xiang17 Awaiting requested review from xiang17 xiang17 is a code owner

@harsimar harsimar Awaiting requested review from harsimar harsimar is a code owner

@jeanbisutti jeanbisutti Awaiting requested review from jeanbisutti jeanbisutti is a code owner

@rajkumar-rangaraj rajkumar-rangaraj Awaiting requested review from rajkumar-rangaraj rajkumar-rangaraj is a code owner

@ramthi ramthi Awaiting requested review from ramthi ramthi is a code owner

@trask trask Awaiting requested review from trask trask is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@xiang17 xiang17

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xiang17