espflash: Reduce the memory fragmentation during flash write. #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-hh
force-pushed
the
drop_fragmentation
branch
from
5dbfd98 to
fffcbc2
Compare
robert-hh
force-pushed
the
drop_fragmentation
branch
from
fffcbc2 to
5a6bc77
Compare
espflash used to implicitely allocate four times per write the ~4k buffer for the data. That caused devices with smaller memory to fail due to memory fragmentation. This change reduces it to once per block. Signed-off-by: robert-hh <robert@hammelrath.com>
robert-hh
force-pushed
the
drop_fragmentation
branch
from
5a6bc77 to
a834485
Compare
Contributor
Author
|
This change was only needed for MIMXRT101x boards with the NINA firmware. Since the related PR was closed, it's not needed any more. |
Member
|
IMO this was a reasonable improvement, always good to reduce memory fragmentation. But I was waiting for the mimxrt WiFi integration to be finished before fully reviewing it, so I never got to it. |
Contributor
Author
|
Thank you for the feedback, and no worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
espflash used to implicitely allocate four times per write the ~4k buffer for the data. That caused boards with smaller memory to fail due to memory fragmentation. This change reduces the allocation to once per block.