ntptime: Reject Kiss-o-Death and zero timestamps. - #1152
Merged
Conversation
Contributor
Author
|
Follow-up: same
|
Contributor
Author
pablogventura
force-pushed
the
ntptime-kod-response
branch
from
September 11, 2026 14:28
a2ff039 to
5aa83ff
Compare
Member
|
Please rebase on latest master. |
Contributor
Author
|
Rebased onto latest
|
pablogventura
force-pushed
the
ntptime-kod-response
branch
from
September 11, 2026 18:05
5aa83ff to
d258999
Compare
dpgeorge
approved these changes
Sep 14, 2026
Fixes issue micropython#604: a Kiss-o-Death reply (stratum 0) or a zero transmit timestamp was accepted. The Y2036 wrap then turned val == 0 into a fake 2036 time, and settime() could apply it. Signed-off-by: Pablo Ventura <pablogventura@gmail.com>
dpgeorge
force-pushed
the
ntptime-kod-response
branch
from
September 14, 2026 00:10
d258999 to
5139530
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
val == 0into a fake 2036 time, andsettime()could apply it.msg[1] == 0orval == 0withOSError(-1). Same error family as a timeout.settime()is unchanged.ntptime-validate-response). This PR also includes that commit until ntptime: Reject short NTP replies. #1151 is merged; rebase ontomasterafter that lands.Test plan
micropython/net/ntptime/test_ntptime.py: valid reply now uses stratum 2; added KoD (stratum 0) and zero timestamp cases.Trade-offs and Alternatives
settime()to returnbool(would break existing callers).ntptime.mpy(mpy-cross, compiled asntptime.py):Delta vs #1151: +20.