zephyr: CMake portability fixes - #6611
Closed
rleigh-lumiradx wants to merge 1 commit into
Closed
rleigh-lumiradx wants to merge 1 commit into
rleigh-lumiradx wants to merge 1 commit into
Conversation
Author
|
One additional comment. Some variables used by mkrules.cmake are defined in ports/esp32/CMakeLists.txt and are not usable by other ports, e.g. zephyr. I wonder if some of these couldn't be factored out into a more general location. One thought I had: Why is the CMake support port-specific? Why not have a generic CMake build which can be used for any platform, and then as the basis for customisation in individual ports. mkrules.cmake gets us part of the way there, but it could be a bit more general than this. |
Member
|
@rleigh-lumiradx now that cmake support is in master, can you please rebase this on master and then I can do a review? |
Author
|
I'll have a look, and see if this is now necessary--it may already have been addressed by the CMake support branch. |
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Aug 2, 2022
Webflow edit page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dpgeorge This PR is based upon the comments I made in #6542 (comment)
It's not directly mergeable, since there were differences between the two branches I've not yet fully reconciled. It looks like some changes were merged which obsoletes some of what I was doing. However, I hope some of the general ideas here are useful:
echoandsedare replaced with CMake-native replacements. This provides for portability beyond UNIX e.g. to Windows