tests/extmod/vfs_fat_ramdisk.py: Fix tests failing on appveyor due to missing uerrno - #2399
tests/extmod/vfs_fat_ramdisk.py: Fix tests failing on appveyor due to missing uerrno#2399deshipu wants to merge 1 commit into
Conversation
|
Appveyor fixed, but Travis died (I think it's unrelated to this change, though). |
|
I would rather enable uerrno on windows build, that should be as simple as adding |
|
That indeed seems like a much saner approach, thanks for pointing it out. |
|
Now this time Travis's failure seems legit https://travis-ci.org/micropython/micropython/builds/158131161#L3669-L3679 I guess we need some additional |
|
Or we could move the |
By enabling uerrno on Windows
|
So I removed the troublesome constants from the Windows build for now. Perhaps they can be found in one of the header files specific to Windows, but I have no way to test that. I guess they could be added when they become needed. |
|
Although there is a comment in moduerrno.c about putting ERROR_LIST in mpconfigport.h, I think it would be good to keep the centralised list in moduerrno.c to prevent too much difference across ports. The windows port does build and pass all other tests so fixing this is not critical for release. Let's wait for @stinos to comment and/or provide a neater solution. |
This is actually long overdue: the README in the windows directory has been updated once to indicate mingw32 is abandoned and not ok to use with uPy, but we forgot travis builds were still using it. As a bonus the travis build will succeed again since moduerrno.c now compiles. (see micropython#2399)
|
Problem is for the mingw cross-compiler only: it builds fine with mingw here (which has EOPNOTSUPP and the others in errno.h, as it should be). looking into this I figured the real problem is travis uses mingw32 which is afaik abandoned and broken. See #2409 for a fix. |
This is actually long overdue: the README in the windows directory has been updated once to indicate mingw32 is abandoned and not ok to use with uPy, but we forgot travis builds were still using it. As a bonus the travis build will succeed again since moduerrno.c now compiles. (see #2399)
This is actually long overdue: the README in the windows directory has been updated once to indicate mingw32 is abandoned and not ok to use with uPy, but we forgot travis builds were still using it. As a bonus the travis build will succeed again since moduerrno.c now compiles. (see micropython#2399)
No description provided.