Repository navigation
psoc-edge: Enable machine.I2C and machine.I2CTarget. - #19772
Open
jaenrig-ifx wants to merge 8 commits into
Open
jaenrig-ifx wants to merge 8 commits into
jaenrig-ifx wants to merge 8 commits into
Conversation
Use the explicit MMIO peripheral and group fields when initializing and deinitializing PCLK clock slaves, since the clk_dest bitfields do not match the MMIO layout. Rename pclk_div_uart_repl_init() to pclk_div_repl_uart_init() and use the configured divider value when setting up the REPL UART clock. Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
Store the SCB MMIO peripheral and group numbers and initialize or deinitialize the associated PCLK slave when the SCB object is allocated or freed. Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19772 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 182 182
Lines 23346 23346
Branches 5 5
=======================================
Hits 23017 23017
Misses 328 328
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
machine.I2Candmachine.I2CTargetclasses.machine.SoftI2C(required intests/extmod_hardware/machine_i2c_target.py).clk: the mmio peripheral group defines were consider equivalent to the peripheral clock destination. They have different values for a given slave peripheral.pclk_div_slave_init()/deinit()toscbshared library.I2Candmachine.I2CTargetinpsoc-edgequick reference docs.psoc-edgesupport to affectedI2C/I2CTargettests.psoc-edgebasic I2C test using both controller and target machine classes.Testing
The following tests have been run for validating I2C enablement:
These tests require a couple of cables connecting SDA and SCL pins.
Additionally, the entire suite has been executed successfully (only skipped tests) in our fork before merging this PR.
Generative AI
I used generative AI tools for this PR to support development validation, review, or line auto-completion.
No (agentic) AI architectural choices, implementation decisions, and/or code automatic generation are part of this PR.