tools/mpremote: Fix test_mount.sh - #19604

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.58%. Comparing base (7d7ac1c) to head (4fd118f).
⚠️ Report is 24 commits behind head on master.

@@            Coverage Diff             @@
##           master   #19604      +/-   ##
==========================================
+ Coverage   98.55%   98.58%   +0.03%     
==========================================
  Files         182      182              
  Lines       23320    23322       +2     
  Branches        5        5              
==========================================
+ Hits        22984    22993       +9     
+ Misses        335      328       -7     
  Partials        1        1              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Code size report:

Reference:  docs/library/ssl: Mention that PEM certificates are now supported. [817b66b]
Comparison: tools/mpremote: Fix errors while running run-mpremote-tests.sh. [merge of 4fd118f]
  mpy-cross:    +0 +0.000% 
   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
      esp32:    +0 +0.000% ESP32_GENERIC
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

test_resume.sh fails for ports/samd ADA_ITSYBITSY_M0:

• expected

  Traceback (most recent call last):
    File "<stdin>", line 1, in <module>
  NameError: name 'a' isn't defined
  

• effective

  Traceback (most recent call last):
    File "<stdin>", line 1, in <module>
  NameError: name not defined
  

This seems to be the cause: https://github.com/micropython/micropython/blob/master/py/runtime.c#L255-L259

#if MICROPY_ERROR_REPORTING <= MICROPY_ERROR_REPORTING_TERSE
mp_raise_msg(&mp_type_NameError, MP_ERROR_TEXT("name not defined"));
#else
mp_raise_msg_varg(&mp_type_NameError, MP_ERROR_TEXT("name '%q' isn't defined"), qst);
#endif

test_resume.sh fails for ports/samd ADA_ITSYBITSY_M0:

I suggest fixing that issue like this:

--- a/tools/mpremote/tests/test_resume.sh
+++ b/tools/mpremote/tests/test_resume.sh
@@ -7,7 +7,7 @@ $MPREMOTE exec "a = 'hello'" eval "a"

 # Automatic soft reset. `a` will trigger NameError.
 echo -----
-$MPREMOTE eval "a" || true
+$MPREMOTE eval "'a' in globals()" || true

 # Resume will skip soft reset.
 echo -----
@@ -16,7 +16,7 @@ $MPREMOTE resume eval "a"

 # The eval command will continue the state of the exec.
 echo -----
-$MPREMOTE exec "a = 'soft-reset'" eval "a" soft-reset eval "1+1" eval "a" || true
+$MPREMOTE exec "a = 'soft-reset'" eval "a" soft-reset eval "1+1" eval "'a' in globals()" || true

 # A disconnect will trigger auto-reconnect.
 echo -----

The expected output of that new expression is False.

I was running two jobs against this branch:

• https://reports.octoprobe.org/github_selfhosted_testrun_703/octoprobe_summary_report.html
• https://reports.octoprobe.org/github_selfhosted_testrun_707/octoprobe_summary_report.html

All tests now correctly pass or skip.

However:

• ESP32_S3_DEVKIT is very unstable
• PYBV11-DP_THREAD once failed

@Josverl: You can review this PR now!

Octoprobe PR report

• Duration: 20min, 221 tests run, 5633ms/test
• Tested ports: esp32 esp8266 mimxrt nrf rp2 samd stm32
• Summary Report , Logdirectory