shared/runtime/pyexec: Don't execute empty line in event driven REPL. - #19587
Open
dpgeorge wants to merge 1 commit into
Open
shared/runtime/pyexec: Don't execute empty line in event driven REPL.#19587dpgeorge wants to merge 1 commit into
dpgeorge wants to merge 1 commit into
Conversation
Commit 617c7db exposed a bug in the event driven REPL code: an empty input line (user pressing enter without entering anything else) would pass a zero-length string to `parse_compile_execute()` and this is not valid input to `mp_lexer_new_from_str_len()`, which requires at least one character in the input string. Fix that by restarting the input REPL state machine when nothing is entered. This follows how the non-event-driver REPL code works. Fixes issue micropython#19583. Signed-off-by: Damien George <damien@micropython.org>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19587 +/- ##
=======================================
Coverage 98.55% 98.55%
=======================================
Files 182 182
Lines 23303 23303
Branches 5 5
=======================================
Hits 22967 22967
Misses 335 335
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Code size report: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commit 617c7db exposed a bug in the event driven REPL code: an empty input line (user pressing enter without entering anything else) would pass a zero-length string to
parse_compile_execute()and this is not valid input tomp_lexer_new_from_str_len(), which requires at least one character in the input string.Fix that by restarting the input REPL state machine when nothing is entered. This follows how the non-event-driver REPL code works.
Fixes issue #19583.
Testing
Tested with webassembly port:
then pressing enter many times in a row. It now correctly just reissues
>>>, rather than raisingSyntaxError.Trade-offs and Alternatives
Could fix it in
mp_lexer_new()by making that handle a zero-length input stream. But that adds code to ports which don't need the fix, and fixing it inpyexec.cfollows exactly how the non-event-driver REPL works.Generative AI
I did not use generative AI tools when creating this PR.