Skip to content

esp32/adc: Raise error if ADC read result is invalid.#18995

Open
DvdGiessen wants to merge 1 commit intomicropython:masterfrom
DvdGiessen:esp32_adc_read_invalid
Open

esp32/adc: Raise error if ADC read result is invalid.#18995
DvdGiessen wants to merge 1 commit intomicropython:masterfrom
DvdGiessen:esp32_adc_read_invalid

Conversation

@DvdGiessen
Copy link
Copy Markdown
Contributor

@DvdGiessen DvdGiessen commented Mar 25, 2026

Summary

The adc_oneshot_read() function returns a status indicating whether the value was read correctly (documentation), but we weren't checking it.

Generative AI

I did not use generative AI tools when creating this PR.

Signed-off-by: Daniël van de Giessen <daniel@dvdgiessen.nl>
@github-actions
Copy link
Copy Markdown

Code size report:

Reference:  esp32/boards/SEEED_XIAO_ESP32C6: Add new XIAO board definition. [2dc2e30]
Comparison: esp32/adc: Raise error if ADC read result is invalid. [merge of e264823]
  mpy-cross:    +0 +0.000% 
   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
      esp32:    +4 +0.000% ESP32_GENERIC
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants