esp32/adc: Raise error if ADC read result is invalid.#18995
Open
DvdGiessen wants to merge 1 commit intomicropython:masterfrom
Open
esp32/adc: Raise error if ADC read result is invalid.#18995DvdGiessen wants to merge 1 commit intomicropython:masterfrom
DvdGiessen wants to merge 1 commit intomicropython:masterfrom
Conversation
Signed-off-by: Daniël van de Giessen <daniel@dvdgiessen.nl>
|
Code size report: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
adc_oneshot_read()function returns a status indicating whether the value was read correctly (documentation), but we weren't checking it.Generative AI
I did not use generative AI tools when creating this PR.