rp2/machine_spi: Don't use DMA channels for SPI transfers. #18578
+15
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18471
Testing
Before this change, the reproduction code in #18471 freezes within ~100 loop iterations. After this change, the reproduction code does not freeze (at least, not within 10k loop iterations).
Trade-offs and Alternatives
I don't know the original motivation for using DMA channels for large SPI transfers, but one downside of this change is that long interrupts could hold up SPI transfers. I don't know how problematic that really is, but users should be writing their interrupts to be efficient anyways.
If a user really want to use DMA channels for large SPI transfers, they can easily do this with the existing MicroPython API. Something like this should work (I've not tested it myself):
An alternative solution could be to enable to the user to select whether they want to use the DMA for large transfers, either when the SPI constructor is called, or when the read/write functions are called.