Repository navigation
Internal Server Error when mod_shib is not installed #60
Description
This came up on the WordPress plugin support forum: https://wordpress.org/support/topic/sibboleth-installation-internal-server-error/
It's fair to say that we do expect people to install the mod_shib package before installing our plugin, but it might also be good to not take their site offline. In that ticket, I suggest wrapping the Shibboleth configuration directives in an IfModule block, as in:
<IfModule mod_shib>
AuthType shibboleth
Require shibboleth
</IfModule>Is this something that we would be interested in adding to the core plugin? If so, I'd be happy to create a pull request.
Activity
michaelryanmcneill commentedon May 28, 2020
I think that is a great idea and is something we probably should do in the first place. If you have time @jrchamp and want to put this into a quick PR, that'd be great. If not, I'll try to take care of it next week during my routine maintenance work.
Adding <IfModule> flags to prevent fatal errors on installs without m…
michaelryanmcneill commentedon Jun 17, 2020
This will be implemented in the pending 2.2 release. Thanks for the suggestion @jrchamp!
michaelryanmcneill commentedon Jun 18, 2020
Reopened because of the issues found in #64. Once we hear back from the reporters, we can attempt to resolve the issue in cPanel environments.
jdpurdyvi commentedon Jun 18, 2020
From my sysadmin
That said, php is also running with fcgi and not mod_php
1 remaining item
jdpurdyvi commentedon Jun 18, 2020
PHP is running with fcgi so apache_get_modules() is not available e.g.
[18-Jun-2020 20:39:34 UTC] PHP Fatal error: Uncaught Error: Call to undefined function apache_get_modules() in /my/wp/path:57michaelryanmcneill commentedon Jun 18, 2020
Haha, of course it is. Can you try seeing if the module name shows up in
phpinfo()?jdpurdyvi commentedon Jun 19, 2020
Short answer is no. But I sent you the full output of phpinfo() privately @michaelryanmcneill in case you want to verify.
dandalpiaz commentedon Jun 20, 2020
The admins for our cPanel host said that they were able to make things work by using the filename instead of the identifier for the module:
<IfModule mod_shib.cpp>Not sure if that will be the case for all cPanel environments though.
jrchamp commentedon Jun 21, 2020
mod_shib.cppmakes sense because the Shibboleth SP module is written in C++.Adding additional conditionals to fully resolve #60
michaelryanmcneill commentedon Jun 21, 2020
Just to be safe, I've gone ahead and added
mod_shib.candmod_shib.cppin addition tomod_shib. I've committed it with 7affc23 and I've created a draft release. If @dandalpiaz, @jdpurdyvi, and @jrchamp (and others) could test it out before I release it to the WordPress.org repository, that would be wonderful. I want to try and avoid breaking things for others again if possible. If I don't hear anything back I'll release it on Tuesday afternoon.jrchamp commentedon Jun 21, 2020
I tested this configuration on my test system and it's working for me, but the previous change did also.
michaelryanmcneill commentedon Jun 21, 2020
Thanks @jrchamp!
jdpurdyvi commentedon Jun 21, 2020
mod_shib.cppis what works on my host. Thanks!dandalpiaz commentedon Jun 22, 2020
The
mod_shib.cppconditional is working on our cPanel host as well. Thanks @michaelryanmcneill !michaelryanmcneill commentedon Jun 22, 2020
Great, with these confirmations, I'll merge these changes and push the release out.
Merge pull request #67 from michaelryanmcneill/2.2.2-alpha