add missing fields when cloning

michael-ameri · michael-ameri · commit 4bbbe774469a · 2025-01-12T23:03:31.000+01:00
diff --git a/src/main/java/org/json/JSONParserConfiguration.java b/src/main/java/org/json/JSONParserConfiguration.java
@@ -27,7 +27,9 @@ public JSONParserConfiguration() {
     protected JSONParserConfiguration clone() {
         JSONParserConfiguration clone = new JSONParserConfiguration();
         clone.overwriteDuplicateKey = overwriteDuplicateKey;
+        clone.strictMode = strictMode;
         clone.maxNestingDepth = maxNestingDepth;
+        clone.keepStrings = keepStrings;
         return clone;
     }
 
diff --git a/src/test/java/org/json/junit/JSONParserConfigurationTest.java b/src/test/java/org/json/junit/JSONParserConfigurationTest.java
@@ -14,7 +14,10 @@
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertThrows;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
 
 public class JSONParserConfigurationTest {
     private static final String TEST_SOURCE = "{\"key\": \"value1\", \"key\": \"value2\"}";
@@ -32,6 +35,24 @@ public void testOverwrite() {
         assertEquals("duplicate key should be overwritten", "value2", jsonObject.getString("key"));
     }
 
+    @Test
+    public void strictModeIsCloned(){
+        JSONParserConfiguration jsonParserConfiguration = new JSONParserConfiguration()
+                .withStrictMode(true)
+                .withMaxNestingDepth(12);
+
+        assertTrue(jsonParserConfiguration.isStrictMode());
+    }
+
+    @Test
+    public void maxNestingDepthIsCloned(){
+        JSONParserConfiguration jsonParserConfiguration = new JSONParserConfiguration()
+                .<JSONParserConfiguration>withKeepStrings(true)
+                .withStrictMode(true);
+
+        assertTrue(jsonParserConfiguration.isKeepStrings());
+    }
+
     @Test
     public void verifyDuplicateKeyThenMaxDepth() {
         JSONParserConfiguration jsonParserConfiguration = new JSONParserConfiguration()

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,9 @@ public JSONParserConfiguration() {`
`27`	`27`	`protected JSONParserConfiguration clone() {`
`28`	`28`	`JSONParserConfiguration clone = new JSONParserConfiguration();`
`29`	`29`	`clone.overwriteDuplicateKey = overwriteDuplicateKey;`
	`30`	`+ clone.strictMode = strictMode;`
`30`	`31`	`clone.maxNestingDepth = maxNestingDepth;`
	`32`	`+ clone.keepStrings = keepStrings;`
`31`	`33`	`return clone;`
`32`	`34`	`}`
`33`	`35`