-
Notifications
You must be signed in to change notification settings - Fork 232
Expand file tree
/
Copy pathtemplateUseTrackByFunctionRule.spec.ts
More file actions
235 lines (219 loc) · 6.24 KB
/
Copy pathtemplateUseTrackByFunctionRule.spec.ts
File metadata and controls
235 lines (219 loc) · 6.24 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
import { Rule } from '../src/templateUseTrackByFunctionRule';
import { assertAnnotated, assertMultipleAnnotated, assertSuccess } from './testHelper';
const {
FAILURE_STRING,
metadata: { ruleName },
} = Rule;
describe(ruleName, () => {
describe('failure', () => {
it('should fail when trackBy function is not present', () => {
const source = `
@Component({
template: \`
<ul>
<li *ngFor="let item of [1, 2, 3];">
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
{{ item }}
</li>
</ul>
\`
})
class Bar {}
`;
assertAnnotated({ message: FAILURE_STRING, ruleName, source });
});
it('should fail when trackBy is missing colon', () => {
const source = `
@Component({
template: \`
<div *ngFor="let item of [1, 2, 3]; trackBy trackByFn">
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
{{ item }}
</div>
\`
})
class Bar {}
`;
assertAnnotated({ message: FAILURE_STRING, ruleName, source });
});
it('should fail when [ngForTrackBy] is missing in ng-template', () => {
const source = `
@Component({
template: \`
<ng-template ngFor let-item [ngForOf]="[1, 2, 3]" let-i="index">
~~~~~~~~~~~~~~~~~~~~~
{{ item }}
</ng-template>
\`
})
class Bar {}
`;
assertAnnotated({ message: FAILURE_STRING, ruleName, source });
});
it('should fail when there are two ngFor and for the second, trackBy function is not present', () => {
const source = `
@Component({
template: \`
<div *ngFor="let item of [1, 2, 3]; trackBy: trackByFn">
{{ item }}
</div>
<ul>
<li *ngFor="let item of [1, 2, 3];">
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
{{ item }}
</li>
</ul>
\`
})
class Bar {}
`;
assertAnnotated({ message: FAILURE_STRING, ruleName, source });
});
it('should fail when trackBy function is missing in multiple *ngFor', () => {
const source = `
@Component({
template: \`
<div *ngFor="let item of [1, 2, 3];">
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
{{ item }}
</div>
<ng-template ngFor let-item [ngForOf]="[1, 2, 3]" let-i="index">
^^^^^^^^^^^^^^^^^^^^^
{{ item }}
</ng-template>
\`
})
class Bar {}
`;
assertMultipleAnnotated({
failures: [
{
char: '~',
msg: FAILURE_STRING,
},
{
char: '^',
msg: FAILURE_STRING,
},
],
ruleName,
source,
});
});
});
describe('success', () => {
it('should succeed when trackBy function is present', () => {
const source = `
@Component({
template: \`
<div *ngFor="let item of [1, 2, 3]; trackBy: trackByFn">
{{ item }}
</div>
\`
})
class Bar {}
`;
assertSuccess(ruleName, source);
});
it('should succeed when trackBy function and exported index value are present', () => {
const source = `
@Component({
template: \`
<div *ngFor="let item of [1, 2, 3]; let i = index; trackBy: trackByFn">
{{ item }}
</div>
\`
})
class Bar {}
`;
assertSuccess(ruleName, source);
});
it('should succeed when trackBy function is present and has trailing spaces', () => {
const source = `
@Component({
template: \`
<div *ngFor="let item of [1, 2, 3]; trackBy : trackByFn">
{{ item }}
</div>
\`
})
class Bar {}
`;
assertSuccess(ruleName, source);
});
it('should succeed when trackBy function is present and *ngFor uses single quotes', () => {
const source = `
@Component({
template: \`
<div *ngFor='let item of [1, 2, 3]; let i = index; trackBy: trackByFn'>
{{ item }}
</div>
\`
})
class Bar {}
`;
assertSuccess(ruleName, source);
});
it('should succeed when *ngFor is surrounded by a lot of whitespaces', () => {
const source = `
@Component({
template: \`
<div *ngFor = "let item of [1, 2, 3]; let i = index; trackBy : trackByFn">
{{ item }}
</div>
\`
})
class Bar {}
`;
assertSuccess(ruleName, source);
});
it('should succeed when [ngForTrackBy] is present in ng-template', () => {
const source = `
@Component({
template: \`
<ng-template ngFor let-item [ngForOf]="[1, 2, 3]" let-i="index"
[ngForTrackBy]="trackByFn">
{{ item }}
</ng-template>
\`
})
class Bar {}
`;
assertSuccess(ruleName, source);
});
it('should succeed when trackBy function is present in multiple *ngFor', () => {
const source = `
@Component({
template: \`
<div *ngFor="let item of ['a', 'b', 'c']; index as i; trackBy: trackByFn">
{{ item }}
</div>
<ng-template ngFor let-item [ngForOf]="[1, 2, 3]" let-i="index"
[ngForTrackBy]="trackByFn">
{{ item }}
</ng-template>
\`
})
class Bar {}
`;
assertSuccess(ruleName, source);
});
it('should succeed when trackBy function is on a different line', () => {
const source = `
@Component({
template: \`
<div *ngFor="
let item of [1, 2, 3];
let i = index;
trackBy : trackByFn
">
{{ item }}
</div>
\`
})
class Bar {}
`;
assertSuccess(ruleName, source);
});
});
});