Skip to content

ci: Publish to GHCR, update actions - #52

Merged
mendhak merged 2 commits into
mendhak:masterfrom
bjw-s:master
Mar 16, 2023
Merged

ci: Publish to GHCR, update actions#52
mendhak merged 2 commits into
mendhak:masterfrom
bjw-s:master

Conversation

@bjw-s

@bjw-s bjw-s commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

This PR aims to publish the Docker image to both Docker Hub and GitHub Container Registry

fixes #51

Comment thread .github/workflows/build.yml
@bjw-s

bjw-s commented Mar 16, 2023

Copy link
Copy Markdown
Contributor Author

I see that the CI has failed, but I wonder if / how that is because of anything that I changed?

@mendhak

mendhak commented Mar 16, 2023

Copy link
Copy Markdown
Owner

Ah I think I see it, there's a breaking change in the anchore scan-action v3: "Change default behavior so action fails on medium (and higher) severities"

Indeed, I reran this PR's build and it's failing at a medium severity. https://github.com/mendhak/docker-http-https-echo/actions/runs/4435829661/jobs/7795945655#step:9:34

There's an argument for the action, severity-cutoff can be set to high, or we can go back to v2. I can investigate the medium severity later.

@mendhak
mendhak merged commit d7e8906 into mendhak:master Mar 16, 2023
@mendhak

mendhak commented Mar 16, 2023

Copy link
Copy Markdown
Owner

I think that's it, working now.
I created a test tag ghcr and the publish ran just fine.

https://github.com/mendhak/docker-http-https-echo/pkgs/container/http-https-echo

docker run -p 8080:8080 -p 8443:8443 --rm -t ghcr.io/mendhak/http-https-echo:latest

I'll update the README CHANGELOG etc in a bit. And some cleaning up to do. No idea how I did this, must have been some experimenting.

image

@ghost
ghost deleted the master branch December 7, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide alternate image registry to Docker Hub

2 participants