Correcting vertical-rl and vertical-lr descriptions.#43585
Merged
chrisdavidmills merged 2 commits intomdn:mainfrom Mar 27, 2026
Merged
Correcting vertical-rl and vertical-lr descriptions.#43585chrisdavidmills merged 2 commits intomdn:mainfrom
chrisdavidmills merged 2 commits intomdn:mainfrom
Conversation
Updated the descriptions so that the next vertical line is always positioned according to the writing mode, independent of script direction. fixes: mdn#43546
mohammed-ali-osman
requested review from
chrisdavidmills
and removed request for
a team
github-actions
bot
added
Content:CSS
Contributor
|
Preview URLs (1 page) (comment last updated: 2026-03-27 08:37:24) |
chrisdavidmills
requested changes
Mar 27, 2026
Contributor
chrisdavidmills
left a comment
chrisdavidmills
left a comment
There was a problem hiding this comment.
Your "left"/"right" corrections look fine; I would remove the instances of "always" that you've added, as they are not needed, and they imply that the first sentence in each case might not be "always". Better to keep it consistent.
Contributor
Author
|
Hello @chrisdavidmills! That’s a great point about the consistency between the two sentences. I’ve removed 'always' from both descriptions to keep the tone uniform. Thanks for the catch! |
chrisdavidmills
approved these changes
Mar 27, 2026
Contributor
chrisdavidmills
left a comment
chrisdavidmills
left a comment
There was a problem hiding this comment.
@mohammed-ali-osman perfect; let's get this in!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated the descriptions so that the next vertical line is always positioned according to the writing mode, independent of script direction.
both
vertical-rlandvertical-lrshare:vertical-rl: lines stack to the left.vertical-lr: lines stack to the right.Fixes #43546