fix: Add timeout option to stdio #422
Open
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ API Documentation Out of DateThe API documentation needs to be regenerated. Please run the following commands: cd docs
python generate_docs.py ../libraries/python/mcp_use python/api-reference docs.jsonThen commit the changes: git add docs/
git commit -m "docs: update API documentation"Modified files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a configurable
timeoutparameter for theStdioConnectorandStdioConnectionManagerto address issues with hardcoded process termination timeouts for stdio-based servers.Previously, the timeout for terminating a stdio server process was not configurable through the
StdioConnector, which could lead to premature process termination if a server required a longer-than-default time to shut down gracefully.This change exposes the
timeoutsetting in theStdioConnector, allowing developers to specify a custom duration to wait for the server process to exit. The provided timeout value is then used to override the globalPROCESS_TERMINATION_TIMEOUTin the underlyingmcpclient library for the scope of the connection.Changes Made
timeoutparameter toStdioConnectorwith a default value imported frommcp.client.stdio.PROCESS_TERMINATION_TIMEOUT.timeoutparameter fromStdioConnectortoStdioConnectionManager.StdioConnectionManager, thetimeoutis used to dynamically set themcp.client.stdio.PROCESS_TERMINATION_TIMEOUTvalue, making the timeout configurable per connection.This fix is a try to solve hardcoding... Fixes #404