Add support for Multi-phase extension module initialization PEP489#105
Closed
rcmcdonald91 wants to merge 1 commit intomaxmind:mainfrom
Closed
Add support for Multi-phase extension module initialization PEP489#105rcmcdonald91 wants to merge 1 commit intomaxmind:mainfrom
rcmcdonald91 wants to merge 1 commit intomaxmind:mainfrom
Conversation
Contributor
Author
Contributor
Author
|
This likely requires a broader discussion on the minimum python version we want to support. |
Member
|
We generally support all Python versions that are still getting security updates upstream. That would mean that we will want to support 3.7 until June. I haven't looked too closely at the code yet, but it would be fine to conditionally compile blocks of code for particular Python versions. |
Member
|
This was done in #267 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Py_INCREFthat can cause segfaults when used by embedded interpreters.