Skip to content

Require older yapf #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nchelluri merged 2 commits into from
Dec 12, 2019
Merged

Require older yapf #83

nchelluri merged 2 commits into from
Dec 12, 2019

Conversation

@oschwald
Copy link
Member

@oschwald oschwald commented Dec 12, 2019

With 0.29.0, we ran into google/yapf#781,
which made pylint unhappy and makes the arg list harder to read.

@oschwald
Require older yapf
da5381d 
With 0.29.0, we ran into google/yapf#781,
which made pylint unhappy and makes the arg list harder to read.
@oschwald
Test on Python 3.8
84f0e30
@coveralls
Copy link

coveralls commented Dec 12, 2019

Coverage Status

Coverage increased (+0.7%) to 97.846% when pulling 84f0e30 on greg/require-yapf-0.28.0 into 02834b2 on master.

nchelluri
nchelluri approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@nchelluri nchelluri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nchelluri nchelluri merged commit 2a9f2cd into master Dec 12, 2019
@nchelluri nchelluri deleted the greg/require-yapf-0.28.0 branch December 12, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nchelluri nchelluri nchelluri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oschwald @coveralls @nchelluri