feat: check integrity of cached binaries

robertnurnberg · ppigazzini · commit 358679dc578a · 2025-09-18T14:29:05.000+02:00
Raise worker version to 295 (also server side) Using suggestion by @MinetaS Fixes official-stockfish#2389
diff --git a/server/fishtest/api.py b/server/fishtest/api.py
@@ -36,7 +36,7 @@
 according to the route/URL mapping defined in `__init__.py`.
 """
 
-WORKER_VERSION = 294
+WORKER_VERSION = 295
 
 
 @exception_view_config(HTTPException)
diff --git a/worker/games.py b/worker/games.py
@@ -808,6 +808,20 @@ def create_environment():
     return env, env_hash
 
 
+def engine_is_healthy(path: Path, timeout_s: float = 5.0):
+    try:
+        r = subprocess.run(
+            [str(path), "bench", "16", "1", "5", "default", "depth"],
+            stdout=subprocess.DEVNULL,
+            stderr=subprocess.DEVNULL,
+            check=False,
+            timeout=timeout_s,
+        )
+        return r.returncode == 0
+    except (OSError, subprocess.SubprocessError):
+        return False
+
+
 def setup_engine(
     testing_dir,
     remote,
@@ -824,10 +838,19 @@ def setup_engine(
     engine_path = (testing_dir / (engine_name + "-old")).with_suffix(EXE_SUFFIX)
     engine_path_native = (testing_dir / engine_name).with_suffix(EXE_SUFFIX)
     for path in (engine_path_native, engine_path):
-        if path.exists():
+        if not path.exists():
+            continue
+
+        if engine_is_healthy(path):
             update_atime(path)
             return path
 
+        print(f"Removing invalid engine {path}")
+        try:
+            path.unlink()
+        except Exception as e:
+            raise WorkerException(f"Failed to remove cached engine {path}:\n{e}")
+
     """Download and build sources in a temporary directory then move exe as engine_path"""
     worker_dir = testing_dir.parent
     tmp_dir = Path(tempfile.mkdtemp(dir=worker_dir))
diff --git a/worker/sri.txt b/worker/sri.txt
@@ -1 +1 @@
-{"__version": 294, "updater.py": "eDDBPKA/vrTCadgtEJFdL06vSoiysF0JhiHKdEnjQv3zS4kfdOAqnco/DJpDWbvh", "worker.py": "3yyZwB+V8zbs7IwsuUWniKWC2zL2J2fpMfENAvRsanwVtVqFvtw4KcN4BZupJvnV", "games.py": "VdcZIM4EsM66WnU4FzIlHOWRrsJrgpxiFVyN9rG4KMdNGmQsZ6JbgAJUrvXOOMJx"}
+{"__version": 295, "updater.py": "eDDBPKA/vrTCadgtEJFdL06vSoiysF0JhiHKdEnjQv3zS4kfdOAqnco/DJpDWbvh", "worker.py": "LFWwPl6NeiFOWQzj5TPiMPuP0wdaS22jLJMa2PLyhl9F8rSemFPNq3Rpk7tKf5uk", "games.py": "sbNzCoZRY4NoJoOYMVevv0JRbfRWYndkukrXe2krhD6h3ktmo2YL/Z5NTJyY96iL"}
diff --git a/worker/worker.py b/worker/worker.py
@@ -73,7 +73,7 @@
 
 FASTCHESS_SHA = "66cac47f06dc1a09d3d1865cdbf560a7814f82ea"
 
-WORKER_VERSION = 294
+WORKER_VERSION = 295
 FILE_LIST = ["updater.py", "worker.py", "games.py"]
 HTTP_TIMEOUT = 30.0
 INITIAL_RETRY_TIME = 15.0

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{"__version": 294, "updater.py": "eDDBPKA/vrTCadgtEJFdL06vSoiysF0JhiHKdEnjQv3zS4kfdOAqnco/DJpDWbvh", "worker.py": "3yyZwB+V8zbs7IwsuUWniKWC2zL2J2fpMfENAvRsanwVtVqFvtw4KcN4BZupJvnV", "games.py": "VdcZIM4EsM66WnU4FzIlHOWRrsJrgpxiFVyN9rG4KMdNGmQsZ6JbgAJUrvXOOMJx"}`
	`1`	`+{"__version": 295, "updater.py": "eDDBPKA/vrTCadgtEJFdL06vSoiysF0JhiHKdEnjQv3zS4kfdOAqnco/DJpDWbvh", "worker.py": "LFWwPl6NeiFOWQzj5TPiMPuP0wdaS22jLJMa2PLyhl9F8rSemFPNq3Rpk7tKf5uk", "games.py": "sbNzCoZRY4NoJoOYMVevv0JRbfRWYndkukrXe2krhD6h3ktmo2YL/Z5NTJyY96iL"}`