Skip to content

give the session for test requests an ephemeral (in memory) cache. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattpolzin merged 1 commit into from
Jul 23, 2020
Merged

give the session for test requests an ephemeral (in memory) cache. #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Sources/JSONAPISwiftGen/Swift Generators/Test Generators/APIRequestTestSwiftGen.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,11 @@ public struct APIRequestTestSwiftGen: SwiftGenerator {

private let makeTestRequestFunc = #"""

/// A session stored globally that does not cache responses on disk.
let session = URLSession(
configuration: .ephemeral
)

/// Log warning after test case logs
func XCTWarn(_ message: String, at url: URL) {
print("[\(url.absoluteString)] : warning - \(message)")
Expand Down Expand Up @@ -401,7 +406,7 @@ func makeTestRequest<RequestBody>(
completionExpectation.fulfill()
}

let task = URLSession.shared.dataTask(with: request, completionHandler: taskCompletion)
let task = session.dataTask(with: request, completionHandler: taskCompletion)
task.resume()

XCTWaiter().wait(for: [completionExpectation], timeout: 5)
Expand Down
7 changes: 6 additions & 1 deletion Tests/JSONAPISwiftGenTests/APIRequestTestSwiftGenTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ final class APIRequestTestSwiftGenTests: XCTestCase {
}

// MARK: - START - Function written to generated test suites
/// A session stored globally that does not cache responses on disk.
let session = URLSession(
configuration: .ephemeral
)

/// Log warning after test case logs
func XCTWarn(_ message: String, at url: URL) {
print("[\(url.absoluteString)] : warning - \(message)")
Expand Down Expand Up @@ -178,7 +183,7 @@ func makeTestRequest<RequestBody>(
completionExpectation.fulfill()
}

let task = URLSession.shared.dataTask(with: request, completionHandler: taskCompletion)
let task = session.dataTask(with: request, completionHandler: taskCompletion)
task.resume()

XCTWaiter().wait(for: [completionExpectation], timeout: 5)
Expand Down