Added conn.commit() to actually save the table in the db#204
Merged
mattmakai merged 1 commit intomattmakai:masterfrom Feb 15, 2019
Merged
Added conn.commit() to actually save the table in the db#204mattmakai merged 1 commit intomattmakai:masterfrom
mattmakai merged 1 commit intomattmakai:masterfrom
Conversation
Need to add conn.commit() to save the table else when you go to view the table in a db manager it will not exsist
Owner
|
cool thanks @josephpaulmckenzie. hmm it's been awhile since I wrote the post I could've sworn only DML changes needed a commit not DDL. but if you tested and it's required that makes sense |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to add conn.commit() to save the table else when you go to view the table in a db manager it will not exist.Also added a conn.close() to close out the connection after creating the table or inserting new data