Closed
Conversation
mattmakai
added a commit
that referenced
this pull request
May 31, 2018
Owner
|
hmm, the Data Skeptic link was my fault. i left out the "www" in the domain. pylons book I removed manually. I'm going to close this PR but these should be fixed via latest commit now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor changes since last time. I ran
check_urlsagainst these links a couple of times within the past 3 days just to make sure it wasn't a fluke.Note: It turns out I still have to manually check the bad links dictionary since each link might get timeout due to a bad/slow network on my side and intermittent errors on the site. Nevertheless, the script is a good starting point for pinpointing errors since it tends to returns few results.
Note: The timeout threshold might need to be configurable in the future. Can also consider implementing retries for
GETcalls with backoff (tradeoff being slower execution).