Skip to content
This repository was archived by the owner on Mar 13, 2024. It is now read-only.

Conversation

@nevyangelova
Copy link
Contributor

Summary

Fix emoji sprite display in Firefox

Ticket Link

https://mattermost.atlassian.net/browse/MM-49559

Release Note

NONE

@nevyangelova nevyangelova added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Jan 9, 2023
@mattermost-build
Copy link
Contributor

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

@nevyangelova nevyangelova added QA Deferred Agreement with QA that these changes will be tested post-merge and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Jan 9, 2023
@mattermost-build
Copy link
Contributor

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

@lieut-data
Copy link
Member

@nevyangelova, will this also fix an issue with rendering stretched emojis in replies to posts?

image

@nevyangelova
Copy link
Contributor Author

@lieut-data fixed :)

@nevyangelova nevyangelova merged commit 2eafc2e into master Jan 10, 2023
@nevyangelova nevyangelova deleted the MM-49559 branch January 10, 2023 12:35
@amyblais
Copy link
Member

/cherry-pick release-7.7

@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit to mattermost-build/mattermost-webapp that referenced this pull request Jan 10, 2023
* [MM-49559] - Fix emoji sprite in mozila firefox

* fix wrong value

* Fix reaction

* linter

Co-authored-by: Nevyana Angelova <nevyangelova@Nevyanas-MacBook-Pro.local>
(cherry picked from commit 2eafc2e)
@mattermost-build mattermost-build added the CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone label Jan 10, 2023
@amyblais
Copy link
Member

/cherry-pick cloud

@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit to mattermost-build/mattermost-webapp that referenced this pull request Jan 10, 2023
* [MM-49559] - Fix emoji sprite in mozila firefox

* fix wrong value

* Fix reaction

* linter

Co-authored-by: Nevyana Angelova <nevyangelova@Nevyanas-MacBook-Pro.local>
(cherry picked from commit 2eafc2e)
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 10, 2023
amyblais pushed a commit that referenced this pull request Jan 10, 2023
* [MM-49559] - Fix emoji sprite in mozila firefox

* fix wrong value

* Fix reaction

* linter

Co-authored-by: Nevyana Angelova <nevyangelova@Nevyanas-MacBook-Pro.local>
(cherry picked from commit 2eafc2e)

Co-authored-by: na <nevyana.angelova@mattermost.com>
mattermost-build added a commit that referenced this pull request Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Deferred Agreement with QA that these changes will be tested post-merge release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants