Skip to content

MM-60878 Fix bug when you press PgUp/PgDown on a long message with sidebar open #29272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
harshilsharma63 merged 2 commits into from
Dec 4, 2024
Merged

MM-60878 Fix bug when you press PgUp/PgDown on a long message with sidebar open #29272

harshilsharma63 merged 2 commits into from
Dec 4, 2024

Conversation

@lorumic
Copy link
Contributor

@lorumic lorumic commented Nov 14, 2024

Summary

Fixed a bug caused by CSS transform, which was making some large white space appear on the right side of the page when the Page Up or Page Down keys were pressed inside a long (scrollable) message while also having a right sidebar open.

Ticket Link

Fixes #28436
Jira https://mattermost.atlassian.net/browse/MM-60878

Release Note

Fixed a bug when you press Page Up or Page Down on a long message (scrollable) with the right sidebar open.

@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 14, 2024
@mattermost-build
Copy link
Contributor

mattermost-build commented Nov 14, 2024

Hello @lorumic,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@lorumic lorumic mentioned this pull request Nov 14, 2024
Closed
@hanzei hanzei requested review from a team and hmhealey November 15, 2024 08:30
@hanzei hanzei added the 2: Dev Review Requires review by a developer label Nov 15, 2024
@hanzei hanzei requested review from a team and removed request for a team November 15, 2024 08:30
@mattermost-build
Copy link
Contributor

mattermost-build commented Nov 26, 2024

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@hmhealey hmhealey changed the title Fix bug when you press PgUp/PgDown on a long message with sidebar open MM-60878 Fix bug when you press PgUp/PgDown on a long message with sidebar open Dec 3, 2024
hmhealey
hmhealey approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@hmhealey hmhealey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @lorumic, and sorry for the delay in reviewing it.

I haven't been able to reproduce the bug in the original report, but I haven't been able to break this in various browsers or screen sizes, so I'm good with accepting this as a fix for the linked issue

@hmhealey hmhealey added the 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review label Dec 3, 2024
@unified-ci-app
Copy link
Contributor

unified-ci-app bot commented Dec 3, 2024

E2E test triggered successfully for PR #29272. The corresponding commit's status check will be available shortly.

@github-actions
Copy link

github-actions bot commented Dec 3, 2024

E2E test run is starting for commit f4702f5d8cbd0a2642262ac0e39c4d2e712fc775.
To check the run progress:

  • Cypress: look for commit status E2E Tests/test or the access the Automation Dashboard Cycle URL.
  • Playwright: look for commit status E2E Tests/test-playwright.

You can also look at the E2E test's Workflow Run URL (run ID 12149014544).

@hmhealey
Copy link
Member

hmhealey commented Dec 3, 2024

/update-branch

@github-actions
Copy link

github-actions bot commented Dec 3, 2024

E2E test has completed for commit f4702f5d8cbd0a2642262ac0e39c4d2e712fc775.
Results summary:

  • Cypress: pass rate is 99.49% (see Automation Dashboard and commit status check E2E Tests/test).
  • Playwright: pass rate is 100.00% (see commit status check E2E Tests/test-playwright).

The run summary artifacts are available in the corresponding Workflow Run.

@yasserfaraazkhan yasserfaraazkhan added the Setup Cloud Test Server Setup an on-prem test server label Dec 4, 2024
@harshilsharma63 harshilsharma63 merged commit 43d589b into mattermost:master Dec 4, 2024
15 checks passed
@mattermost-build mattermost-build removed the Setup Cloud Test Server Setup an on-prem test server label Dec 4, 2024
@mm-cloud-bot
Copy link

mm-cloud-bot commented Dec 4, 2024

Test server destroyed

@mm-cloud-bot
Copy link

mm-cloud-bot commented Dec 4, 2024

Test server destroyed

@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Dec 4, 2024
isacikgoz pushed a commit that referenced this pull request Dec 6, 2024
@lorumic @mattermost-build @isacikgoz
Fix bug when you press PgUp/PgDown on a long message with sidebar open (
08425c0 
#29272)

Co-authored-by: Mattermost Build <build@mattermost.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hmhealey hmhealey hmhealey approved these changes

@yasserfaraazkhan yasserfaraazkhan yasserfaraazkhan approved these changes

@harshilsharma63 harshilsharma63 harshilsharma63 approved these changes

Assignees

No one assigned

Labels

2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review Changelog/Done Required changelog entry has been written Contributor Docs/Not Needed Does not require documentation release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug when you press page up or page down

8 participants

@lorumic @mattermost-build @hmhealey @mm-cloud-bot @yasserfaraazkhan @harshilsharma63 @hanzei @amyblais