Skip to content

GH-29265: Fix errcheck errors in server/channels/app/platform/feature_flags.go #29269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanzei merged 2 commits into from
Nov 15, 2024
Merged

GH-29265: Fix errcheck errors in server/channels/app/platform/feature_flags.go #29269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b295830
GH-29265: Fix errcheck errors in server/channels/app/platform/feature…
MasWho Nov 14, 2024
a7edc14
Merge branch 'master' into GH-29265_fix-errcheck
hanzei Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion server/.golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ issues:
channels/app/platform/busy_test.go|\
channels/app/platform/cluster_handlers.go|\
channels/app/platform/config_test.go|\
channels/app/platform/feature_flags.go|\
channels/app/platform/helper_test.go|\
channels/app/platform/license.go|\
channels/app/platform/link_cache.go|\
Expand Down
5 changes: 4 additions & 1 deletion server/channels/app/platform/feature_flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ func (ps *PlatformService) updateFeatureFlagValuesFromManagement() {
if oldFlags != newFlags {
ps.logger.Debug("Feature flag change detected, updating config")
*newCfg.FeatureFlags = newFlags
ps.SaveConfig(newCfg, true)
_, _, appErr := ps.SaveConfig(newCfg, true)
if appErr != nil {
ps.logger.Error("Failed to save config with updated feature flags", mlog.Err(appErr))
}
}
}

Expand Down
Loading