Skip to content

GH-29265: Fix errcheck errors in server/channels/app/platform/feature_flags.go #29269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hanzei merged 2 commits into from
Nov 15, 2024
Merged

GH-29265: Fix errcheck errors in server/channels/app/platform/feature_flags.go #29269

hanzei merged 2 commits into from
Nov 15, 2024

Conversation

@mas-who
Copy link
Contributor

@mas-who mas-who commented Nov 14, 2024

Summary

handle app error in PlatformService.updateFeatureFlagValuesFromManagement.

Ticket Link

Fixes #29265

Release Note

NONE

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 14, 2024
@mattermost-build
Copy link
Contributor

mattermost-build commented Nov 14, 2024

Hello @mas-who,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

hanzei
hanzei reviewed Nov 14, 2024
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion

@hanzei hanzei added the 2: Dev Review Requires review by a developer label Nov 14, 2024
@mas-who mas-who force-pushed the GH-29265_fix-errcheck branch from 3a112af to b295830 Compare November 14, 2024 10:18
hanzei
hanzei approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hanzei hanzei requested review from a team and devinbinnie and removed request for a team November 14, 2024 10:22
@devinbinnie devinbinnie added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Nov 14, 2024
@hanzei hanzei added this to the v10.4.0 milestone Nov 15, 2024
@hanzei hanzei merged commit 3da77f2 into mattermost:master Nov 15, 2024
28 checks passed
@hanzei hanzei removed their assignment Nov 15, 2024
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 15, 2024
@jwilander jwilander added the kind/refactor Categorizes issue or PR as related to refactor of production code. label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanzei hanzei hanzei approved these changes

@devinbinnie devinbinnie devinbinnie approved these changes

Assignees

No one assigned

Labels

4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Contributor Docs/Not Needed Does not require documentation kind/refactor Categorizes issue or PR as related to refactor of production code. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

v10.4.0

Development

Successfully merging this pull request may close these issues.

Fix errcheck issues in server/channels/app/platform/feature_flags.go

8 participants

@mas-who @mattermost-build @hanzei @devinbinnie @jwilander @amyblais @mm-cloud-bot @MasWho