Skip to content

Conversation

@mas-who
Copy link
Contributor

@mas-who mas-who commented Nov 14, 2024

Summary

Fixed errcheck lint errors in server/channels/testlib/helpder.go

Ticket Link

Fixes #28752

Release Noteitions or changes.

NONE

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 14, 2024
@mattermost-build
Copy link
Contributor

Hello @mas-who,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hanzei hanzei requested review from a team and Willyfrog and removed request for a team November 14, 2024 10:38
@hanzei hanzei added the 2: Dev Review Requires review by a developer label Nov 14, 2024
@hanzei hanzei self-assigned this Nov 14, 2024
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Nov 14, 2024
@hanzei hanzei added this to the v10.4.0 milestone Nov 14, 2024
@hanzei hanzei merged commit f48fd7b into mattermost:master Nov 14, 2024
28 checks passed
@hanzei
Copy link
Contributor

hanzei commented Nov 14, 2024

Thanks @mas-who 👍

@hanzei hanzei removed their assignment Nov 14, 2024
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 14, 2024
devXpranay pushed a commit to devXpranay/mattermost that referenced this pull request Nov 15, 2024
@jwilander jwilander added the kind/refactor Categorizes issue or PR as related to refactor of production code. label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Contributor Docs/Not Needed Does not require documentation kind/refactor Categorizes issue or PR as related to refactor of production code. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix errcheck issues in server/channels/testlib/helper.go

8 participants