Skip to content

Conversation

@minkyngkm
Copy link
Contributor

@minkyngkm minkyngkm commented Nov 12, 2024

Summary

I found and fixed an issue with the navigation menu. When opened on small screens (less than 992px), the navigation did not automatically close when the screen was resized to a larger. After the fix, it now closes automatically on larger screens.

Ticket Link

Fixes #7590

(before)
before

(after)
after

@mattermost-build
Copy link
Contributor

Hello @minkyngkm,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@minkyngkm
Copy link
Contributor Author

/check-cla

@cwarnermm cwarnermm self-requested a review November 12, 2024 18:57
@cwarnermm cwarnermm added 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Nov 12, 2024
@github-actions
Copy link

Newest code from minkyngkm has been published to preview environment for Git SHA 005f6d9

@cwarnermm cwarnermm requested review from a team and hanzei and removed request for a team November 14, 2024 14:56
@cwarnermm
Copy link
Member

@hanzei - Added you as a reviewer via @core-reviewers. Please reassign as needed.

@cwarnermm cwarnermm added the 1: Dev Review Requires review by a core commiter label Nov 14, 2024
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @minkyngkm!

@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request and removed 1: Dev Review Requires review by a core commiter 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Nov 15, 2024
@cwarnermm cwarnermm merged commit 93835ec into mattermost:master Nov 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3: Reviews Complete All reviewers have approved the pull request Contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Navigation bug

4 participants