-
Notifications
You must be signed in to change notification settings - Fork 609
Fix navigation not closing on large screens #7591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @minkyngkm, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
|
/check-cla |
|
Newest code from minkyngkm has been published to preview environment for Git SHA 005f6d9 |
|
@hanzei - Added you as a reviewer via @core-reviewers. Please reassign as needed. |
hanzei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
cwarnermm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @minkyngkm!
Summary
I found and fixed an issue with the navigation menu. When opened on small screens (less than 992px), the navigation did not automatically close when the screen was resized to a larger. After the fix, it now closes automatically on larger screens.
Ticket Link
Fixes #7590
(before)

(after)
