Skip to content

Conversation

@non-Jedi
Copy link
Collaborator

@non-Jedi non-Jedi commented Oct 3, 2019

Closes #307, #308

Let's just hope CI actually passes for this PR.

@non-Jedi non-Jedi force-pushed the ci-simplify branch 7 times, most recently from c87c64f to 238b3df Compare October 3, 2019 21:56
@non-Jedi
Copy link
Collaborator Author

non-Jedi commented Oct 3, 2019

@poljar python-olm tries to build olm when installed even if /usr/lib/libolm.so already exists. Do you know if there's a way to force it to use the already installed olm binary, or do we really need to continue staying on the path of building olm with each CI run even though a perfectly good olm library (but not python bindings) is available in Ubuntu 18.04?

@poljar
Copy link

poljar commented Oct 4, 2019

Huh? Where do you see it doing that? The only thing that python-olm knows how to build is its own module, that module does link against libolm.

If you mean this line here:

   build/temp.linux-x86_64-3.6/_libolm.c:496:18: fatal error: olm/pk.h: No such file or directory

That means that the installed C libolm library is too old for the python bindings to build.

@non-Jedi
Copy link
Collaborator Author

non-Jedi commented Oct 4, 2019

Ah. Well crap. I obviously misread. Thanks.

@non-Jedi
Copy link
Collaborator Author

non-Jedi commented Oct 4, 2019

@poljar Are you planning on keeping https://pypi.org/project/python-olm/ up-to-date? It currently points to the archived github repo as the homepage instead of the olm repo, so I wasn't sure.

Also now use python-olm from pypi instead of directly using the
(now defunct) git repo.
@poljar
Copy link

poljar commented Oct 4, 2019

Yes. Pointing to the old repo is a mistake. This is the official™ release and is up to date.

@non-Jedi non-Jedi force-pushed the ci-simplify branch 2 times, most recently from 1da1c74 to eee8f53 Compare October 4, 2019 15:18
Sphinx minimum version bumped per
sphinx-doc/sphinx#5870 (comment)
since doc building currently fails on 3.7 CI.
@non-Jedi non-Jedi merged commit c091ea8 into master Oct 4, 2019
@non-Jedi non-Jedi deleted the ci-simplify branch October 4, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants