Conversation
|
(Picking on @uhoreg because he is the most olm-y person I can think of 😄) |
poljar
left a comment
There was a problem hiding this comment.
You might want to bump the version as well. Once the sdk switches to the python bindings on pypi you'll have to bump it anyways.
|
Won't bumping to 3.X cause lots of things to break (CC: @Zil0) ? |
|
Looks like it from the changelogs:
For the sake of not blocking other peoples PRs, I'd rather leave updating the e2e code for another day. |
|
You are not installing python bindings here, just the C lib, the C lib didn't break compatibility. The python bindings are installed via setup.py https://github.com/matrix-org/matrix-python-sdk/blob/master/setup.py#L57 and as we can see the sdk already uses the new bindings. |
|
oh right, cool let's do that then |
|
I don't understand the Travis CI failures 😕 |
|
Even if Travis is still failing, this commit is a progress over the current situation, couldn't it be pushed anyway? |
|
It has to be something to do with the olm installation. Running the tests with tox on my computer doesn't replicate the error, and tox does a pretty good job of isolating the execution environment as far as python code goes. The difference is that my libolm is from my distro's package repos. I'm going to see if I can simplify the CI config a bit when I get a chance and open a new PR (it was originally hacked together when I had less than half a clue what I was doing). Might then be better able to tell what's going on. To me, if we don't have working CI, we shouldn't merge anything else until CI is fixed. |
|
\o/ |
No description provided.