Skip to content

Update travis CI with new olm location#307

Closed
Half-Shot wants to merge 3 commits intomasterfrom
hs/fix-olm
Closed

Update travis CI with new olm location#307
Half-Shot wants to merge 3 commits intomasterfrom
hs/fix-olm

Conversation

@Half-Shot
Copy link
Collaborator

No description provided.

@Half-Shot Half-Shot requested a review from uhoreg May 6, 2019 19:33
@Half-Shot
Copy link
Collaborator Author

(Picking on @uhoreg because he is the most olm-y person I can think of 😄)

Copy link

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to bump the version as well. Once the sdk switches to the python bindings on pypi you'll have to bump it anyways.

@Half-Shot
Copy link
Collaborator Author

Won't bumping to 3.X cause lots of things to break (CC: @Zil0) ?

@Half-Shot
Copy link
Collaborator Author

Looks like it from the changelogs:

BREAKING CHANGE: This release introduces a new API for the Python wrapper,
thanks to Damir Jelić. The new API should be much easier to use for Python
developers. However, this means that existing code will need to be rewritten
to use the new API.

For the sake of not blocking other peoples PRs, I'd rather leave updating the e2e code for another day.

@poljar
Copy link

poljar commented May 6, 2019

You are not installing python bindings here, just the C lib, the C lib didn't break compatibility. The python bindings are installed via setup.py https://github.com/matrix-org/matrix-python-sdk/blob/master/setup.py#L57 and as we can see the sdk already uses the new bindings.

@Half-Shot
Copy link
Collaborator Author

oh right, cool let's do that then

@uhoreg
Copy link
Member

uhoreg commented Jun 3, 2019

I don't understand the Travis CI failures 😕

@claudep
Copy link

claudep commented Oct 3, 2019

Even if Travis is still failing, this commit is a progress over the current situation, couldn't it be pushed anyway?

@non-Jedi
Copy link
Collaborator

non-Jedi commented Oct 3, 2019

It has to be something to do with the olm installation. Running the tests with tox on my computer doesn't replicate the error, and tox does a pretty good job of isolating the execution environment as far as python code goes. The difference is that my libolm is from my distro's package repos. I'm going to see if I can simplify the CI config a bit when I get a chance and open a new PR (it was originally hacked together when I had less than half a clue what I was doing). Might then be better able to tell what's going on.

To me, if we don't have working CI, we shouldn't merge anything else until CI is fixed.

@claudep
Copy link

claudep commented Oct 4, 2019

\o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants