Replace calls of deprecated login methods in examples#306
Closed
sblondon wants to merge 9 commits intomatrix-org:masterfrom
sblondon:replace_login_with_password_method_call
Closed
Replace calls of deprecated login methods in examples#306sblondon wants to merge 9 commits intomatrix-org:masterfrom sblondon:replace_login_with_password_method_call
sblondon wants to merge 9 commits intomatrix-org:masterfrom
sblondon:replace_login_with_password_method_call
Conversation
The examples in samples/ used MatrixClient.login_with_password() and MatrixClient.login_with_password_no_sync(). These calls are replaced by newer MatrixClient.login() method.
Collaborator
|
Hiya, CI appears to be broken and will be fixed by #307 so I'll wait for that before merging. Can you also sign off as stated in https://github.com/matrix-org/matrix-python-sdk/blob/master/CONTRIBUTING.rst :) |
The examples in samples/ used MatrixClient.login_with_password() and MatrixClient.login_with_password_no_sync(). These calls are replaced by newer MatrixClient.login() method. Signed-off-by: Stephane Blondon <stephane.blondon@gmail.com>
…hub.com/sblondon/matrix-python-sdk into replace_login_with_password_method_call
Contributor
Author
|
Thanks for the quick review! :) I added a 'sign-off-by' line in 2dda341 |
|
Looks like this could be pushed now the CI is green again! |
Collaborator
|
He's right. @sblondon, could you please rebase on master so CI passes? |
Also now use python-olm from pypi instead of directly using the (now defunct) git repo.
Sphinx minimum version bumped per sphinx-doc/sphinx#5870 (comment) since doc building currently fails on 3.7 CI.
Contributor
Author
|
After the rebase, the CI is green. However, as the new commits are visible, I guess I failed to do a clean rebase. I done: If you prefer, I can close this PR and create a new one. |
Collaborator
|
Don't worry about it. I'll just cherry-pick your commit. Thanks for updating these. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The examples in
samples/directory usedMatrixClient.login_with_password()andMatrixClient.login_with_password_no_sync(). These calls are replacedby newer
MatrixClient.login()method.