do not return the internal list of joined members #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Oh ya. That's definitely not good. I would say it's better to stick a |
Avoids overwriting the internal _members list with a list of user_ids.
Contributor
Author
|
Looking back at it this was even simpler to fix. Not sure why this line ended up doing things like that. |
Collaborator
|
This likely fixes #206. @Matrixcoffee, please let me know if you see that error again after this patch is merged. |
|
This definitely looks like the cause of #206, so I'm going to assume it's fixed unless I see it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a nice bug here https://github.com/matrix-org/matrix-python-sdk/blob/master/matrix_client/room.py#L87. It causes the _members list of User object to be overwritten, resulting in _members being a list of strings (the display names of the Users).
Obviously there are a lot of different way to fix this, I believe this one is the best but I'm open to suggestions.
Signed-off-by: Valentin Deniaud <valentin.deniaud@inpt.fr>