Handle state events in 'timeline' #198
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 24, 2018 00:55
So we can have full instances of our enum class instead of bare ints.
State events can and should arrive via the timeline. The contents of 'state' in the sync response are actually the state at the beginning of 'timeline'. Spec: https://matrix.org/docs/spec/client_server/r0.3.0.html#syncing Fixes: #195 State events can arrive both through "state" and "timeline"
Author
|
Signed-off-by: Маrtіn vаո Βeіlеn (@coffee:matrix.org) |
Author
|
Right, so the test broke because it was validating the wrong behaviour, which is fixed with this PR. FYI, the example sync response is not representative, because the timeline contains a join event referring to a previous invite state, but that state does not appear in 'state'. Not fixing that, though. |
ghost
closed this
Author
|
Closed in favour of #199 |
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #195
Although the actual fix ended up being only 2 simple extra lines, there's quite some pre-work.
Had to refactor the Enum replacement so I could refer to its constants in the room module, and managed to make it simpler using only 5 SLOC.
Moved
_process_state_eventto the room class as well, which really benefited the next patch needing only 2 SLOC.Suggest a non-squashing merge for this PR.
Tests were fixed blindly. LMK if they broke.