Skip to content

Conversation

@Androbin
Copy link
Contributor

Fixes #146
@non-Jedi /cc
Signed-off-by: Robin Richtsfeld robin.richtsfeld@gmail.com

Signed-off-by: Robin Richtsfeld <robin.richtsfeld@gmail.com>
@non-Jedi
Copy link
Collaborator

LGTM. Thanks! (merged into master)

@non-Jedi non-Jedi closed this Mar 29, 2018
@Androbin Androbin deleted the deprecation branch March 29, 2018 21:58
@ghost
Copy link

ghost commented Mar 30, 2018

I have some comments though.

Other than that, looking good.

@ghost
Copy link

ghost commented Mar 30, 2018

Oh, and to head off the question you will undoubtedly have: I would just drop the recommendation, but maybe @non-Jedi has something to say about that as well. The API is still beta and this is one of those places where it shines through.

@non-Jedi
Copy link
Collaborator

Off the top of my head, it seems like we should just expose _sync as sync. Doesn't seem like something we necessarily need to put a ton of machinery in front of.

@ghost
Copy link

ghost commented Mar 30, 2018

@Half-Shot: You have written a lot of this stuff and seem to have had a plan for deprecating initialsync. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants