Skip to content

ENH: make all of the properties on LineWrapper mappable - #15

Merged
ksunden merged 11 commits into
matplotlib:mainfrom
tacaswell:nu_line2D
Nov 10, 2022
Merged

ksunden merged 11 commits into
matplotlib:mainfrom
tacaswell:nu_line2D

Conversation

@tacaswell

Copy link
Copy Markdown
Member

No description provided.

@tacaswell tacaswell changed the title MNT: make all of the properties on LineWrapper mappable ENH: make all of the properties on LineWrapper mappable Nov 4, 2022
@lgtm-com

lgtm-com Bot commented Nov 4, 2022

Copy link
Copy Markdown

This pull request introduces 1 alert when merging 8ee0882 into de25dd1 - view on LGTM.com

new alerts:

  • 1 for Unused import

@ksunden

ksunden commented Nov 4, 2022

Copy link
Copy Markdown
Member

Running into the difference between Line2D.set_xdata and the existing containers using "x" as the key.

Additionally, the change to LineWrapper probably should escape functions that don't exist (e.g. the animation example has "phase" which is used by other artists, but not the LineWrapper artist, but it is trying to call set_phase)

@tacaswell

Copy link
Copy Markdown
Member Author

I have some more ideas on this....

@lgtm-com

lgtm-com Bot commented Nov 4, 2022

Copy link
Copy Markdown

This pull request introduces 1 alert when merging e4837b2 into de25dd1 - view on LGTM.com

new alerts:

  • 1 for Unused import

@ksunden
ksunden merged commit 3eccc70 into matplotlib:main Nov 10, 2022
@tacaswell
tacaswell deleted the nu_line2D branch November 11, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants