Skip to content

FIX: treat zorder=None as falling back to the default - #9793

Merged
efiring merged 1 commit into
matplotlib:v2.1.xfrom
tacaswell:fix_none_zorder
Nov 16, 2017
Merged

efiring merged 1 commit into
matplotlib:v2.1.xfrom
tacaswell:fix_none_zorder

Conversation

@tacaswell

Copy link
Copy Markdown
Member

closes #9785

PR Summary

If set_zorder gets None as input, fall back to the class level zorder (the default).

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant

@tacaswell tacaswell added this to the v2.1.1 milestone Nov 16, 2017
@jklymak

jklymak commented Nov 16, 2017

Copy link
Copy Markdown
Member

Are grid lines Artists?

@tacaswell

Copy link
Copy Markdown
Member Author

Everything that shows up in the final figure is an artist (eventually) http://matplotlib.org/api/artist_api.html iirc, the grid lines are drawn as part of the Tick classes.

@jklymak jklymak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@efiring
efiring merged commit c66c423 into matplotlib:v2.1.x Nov 16, 2017
@tacaswell
tacaswell deleted the fix_none_zorder branch November 20, 2017 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants