Skip to content

Conversation

@dstansby
Copy link
Member

@dstansby dstansby commented Nov 8, 2017

Reverts #8626, because it broke lots of stuff on master: https://travis-ci.org/matplotlib/matplotlib/builds/298909059

@Kojoley
Copy link
Member

Kojoley commented Nov 8, 2017

I have triggered an additional build on master to see if the problem persistent https://travis-ci.org/matplotlib/matplotlib/builds/299098042
Update: Yes, it is.

@Kojoley Kojoley merged commit f2afc4c into master Nov 8, 2017
@Kojoley Kojoley deleted the revert-8626-Axes-init-speedup branch November 8, 2017 14:23
@efiring
Copy link
Member

efiring commented Nov 8, 2017

Specifically, it broke polar plot tests. Originally it was passing, so either the tests are new, or the changes in polar plotting in the interim are interacting badly with this change. Attn @QuLogic

@QuLogic QuLogic added this to the v2.2 milestone Nov 8, 2017
@QuLogic
Copy link
Member

QuLogic commented Nov 8, 2017

Some of the tests are old, so it's probably something in the new polar options that is broken. I remember having to add seemingly-superfluous reset_ticks, so there's probably some other path that's missing the right trigger.

@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants