Raise minimum WX version to 2.9. #9697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.9 was released in 2010; in fact, *before* 2.8.12 (the previous min version), see https://github.com/wxWidgets/wxPython/releases?after=wxPy-2.9.2.1 Remove some conditional code.
Member
|
There are also a bunch of version checks in |
Contributor
Author
|
done, if I understood your suggestion correctly. |
tacaswell
approved these changes
Nov 7, 2017
dstansby
approved these changes
Nov 7, 2017
Member
|
Does this need a note in what's new? (happy for someone to decide not and merge!) |
Member
|
@dstansby I think updating the install docs is enough here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.9 was released in 2010; in fact, before
2.8.12 (the previous min version), see
https://github.com/wxWidgets/wxPython/releases?after=wxPy-2.9.2.1
Remove some conditional code.
PR Summary
PR Checklist