Skip to content

Fix arcs with very large width/height.#9661

Merged
dstansby merged 1 commit into
matplotlib:masterfrom
QuLogic:fix-arcs
Nov 2, 2017
Merged

Fix arcs with very large width/height.#9661
dstansby merged 1 commit into
matplotlib:masterfrom
QuLogic:fix-arcs

Conversation

@QuLogic

@QuLogic QuLogic commented Nov 2, 2017

Copy link
Copy Markdown
Member

PR Summary

Large width/height triggers a different code path that didn't correctly
draw limited arcs instead of the whole ellipse.

Fixes #9659.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Large width/height triggers a different code path that didn't correctly
draw limited arcs instead of the whole ellipse.

Fixes matplotlib#9659.
@dstansby dstansby merged commit 4d09108 into matplotlib:master Nov 2, 2017
@dstansby dstansby added this to the v2.2 milestone Nov 2, 2017
@dstansby

dstansby commented Nov 2, 2017

Copy link
Copy Markdown
Member

Not sure if this should go in 2.1.1

@dopplershift dopplershift modified the milestones: v2.2, v2.1.1 Nov 2, 2017
@dopplershift

Copy link
Copy Markdown
Contributor

It should, it's a pretty low-risk bug fix.

@dopplershift

Copy link
Copy Markdown
Contributor

@meeseeksdev backport to v2.1.x

@QuLogic QuLogic deleted the fix-arcs branch November 2, 2017 18:58
dstansby added a commit that referenced this pull request Nov 2, 2017
@anntzer anntzer mentioned this pull request Jul 18, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants