Skip to content

Issue 807 auto minor locator - #961

Merged
jdh2358 merged 1 commit into
matplotlib:v1.1.xfrom
WeatherGod:issue-807-AutoMinorLocator
Jun 30, 2012
Merged

Issue 807 auto minor locator#961
jdh2358 merged 1 commit into
matplotlib:v1.1.xfrom
WeatherGod:issue-807-AutoMinorLocator

Conversation

@WeatherGod

@WeatherGod WeatherGod commented Jun 22, 2012

Copy link
Copy Markdown
Member

Possible bugfix for issue #807.

@jdh2358

jdh2358 commented Jun 30, 2012

Copy link
Copy Markdown
Collaborator

I can duplicate the error in issue 807, but when I run with your patch, although it prevents the crash, I still get lots of warnings:

msierig@pinchiepie:~> python test.py
/home/msierig/dev/lib/python2.7/site-packages/matplotlib/ticker.py:1557: RuntimeWarning: divide by zero encountered in double_scalars
  tmin = np.ceil((vmin - t0) / minorstep) * minorstep
/home/msierig/dev/lib/python2.7/site-packages/matplotlib/ticker.py:1557: RuntimeWarning: invalid value encountered in double_scalars
  tmin = np.ceil((vmin - t0) / minorstep) * minorstep
/home/msierig/dev/lib/python2.7/site-packages/matplotlib/ticker.py:1558: RuntimeWarning: divide by zero encountered in double_scalars
  tmax = np.floor((vmax - t0) / minorstep) * minorstep
/home/msierig/dev/lib/python2.7/site-packages/matplotlib/ticker.py:1558: RuntimeWarning: invalid value encountered in double_scalars
  tmax = np.floor((vmax - t0) / minorstep) * minorstep

@jdh2358

jdh2358 commented Jun 30, 2012

Copy link
Copy Markdown
Collaborator

I'm going to merge this now because it is an improvement over what we have and it fixes a legitimate bug. There may be better solutions out there but we can clean later. I need to get 1.1.1 out today for the debian release freeze so I am going to include this.

jdh2358 added a commit that referenced this pull request Jun 30, 2012
@jdh2358
Merge pull request #961 from WeatherGod/issue-807-AutoMinorLocator
7e47149 
Issue 807 auto minor locator
@jdh2358
jdh2358 merged commit 7e47149 into matplotlib:v1.1.x Jun 30, 2012
@mmokrejs mmokrejs mentioned this pull request Jun 27, 2013
Closed
@WeatherGod
WeatherGod deleted the issue-807-AutoMinorLocator branch July 23, 2014 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WeatherGod @jdh2358