Skip to content

TST: add test of normed histogram with unequal bins#9564

Merged
dstansby merged 2 commits into
matplotlib:masterfrom
jakevdp:fix-9557
Oct 25, 2017
Merged

TST: add test of normed histogram with unequal bins#9564
dstansby merged 2 commits into
matplotlib:masterfrom
jakevdp:fix-9557

Conversation

@jakevdp

@jakevdp jakevdp commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

Add test for #9557

@jakevdp

jakevdp commented Oct 24, 2017

Copy link
Copy Markdown
Contributor Author

This should be back-ported to 2.1.x along with #9121

Comment thread lib/matplotlib/tests/test_axes.py Outdated
rng = np.random.RandomState(57483)
t = rng.randn(100)
bins = [-3, -1, -0.5, 0, 1, 5]
mpl_heights, _, _ = plt.hist(t, bins=bins, normed=True)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normed is deprecated!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh! Conflated things. Sorry.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its very confusing!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jklymak

jklymak commented Oct 25, 2017

Copy link
Copy Markdown
Member

Looks good unless the tests bork...

@dstansby dstansby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dstansby dstansby added this to the v2.2 milestone Oct 25, 2017
@dstansby dstansby merged commit ad616c6 into matplotlib:master Oct 25, 2017
@tacaswell tacaswell modified the milestones: v2.2, v2.1.1 Oct 25, 2017
@tacaswell

Copy link
Copy Markdown
Member

@meeseeksdev backport to 2.1.x

@QuLogic

QuLogic commented Oct 25, 2017

Copy link
Copy Markdown
Member

v2.1.x?

@tacaswell

Copy link
Copy Markdown
Member

@meeseeksdev backport to v2.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants