Skip to content

Separate plots in examples w/ multiple plots using ###### - #9479

Closed
ash13 wants to merge 4 commits into
matplotlib:masterfrom
ash13:two-plot-fix
Closed

ash13 wants to merge 4 commits into
matplotlib:masterfrom
ash13:two-plot-fix

Conversation

@ash13

@ash13 ash13 commented Oct 19, 2017

Copy link
Copy Markdown
Contributor

PR Summary

Added ##### to programs which had more than 1 plots to seperate the graph plots at output.

As a part of this:
#8922

Fixed those files which were not already fixed from the list.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak

jklymak commented Oct 20, 2017 •

Copy link
Copy Markdown
Member

Hi @ash13 The tests below indicate issues w/ the pull request. If you can drill down in them, you should get hints as to whats wrong. If you can't figure it out, feel free to ask!

@ash13

ash13 commented Oct 20, 2017

Copy link
Copy Markdown
Contributor Author

sorry @jklymak ! I am quite new to contributing. Could you please help me figure what went wrong?

@dopplershift

Copy link
Copy Markdown
Contributor

Two of the lines you added have > 80 characters, which fails our code style checks. According to the sphinx gallery docs you only need a line of at least 20 '#' characters to make a new cell.

@dstansby dstansby added this to the v2.1.0-doc milestone Oct 21, 2017
ax.plot([1, 2, 3])


###########################################################################################

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new lines need to be < 80 characters long (so ideally 79 characters!)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(otherwise this PR looks good to me!)

@QuLogic QuLogic modified the milestones: v2.1.0-doc, v2.1.1-doc Dec 10, 2017
@jklymak

jklymak commented Jan 19, 2018

Copy link
Copy Markdown
Member

ping @ash13 I think this is close, but it needs a rebase and the various line lengths need to be fixed. Drop a line if you can't sort it all out

@tacaswell tacaswell modified the milestones: v2.1.1-doc, v2.2-doc Feb 12, 2018
@dstansby

Copy link
Copy Markdown
Member

I'm going to close this since it's been dormant for a while, @ash13 leave a comment if you want it re-opened 😄

@dstansby dstansby closed this Dec 15, 2018
@QuLogic QuLogic modified the milestones: v2.2-doc, unassigned Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants