Repository navigation
BUG: Fix savefig GUI in GTK backend - #9410
Merged
Merged
Conversation
tacaswell
approved these changes
Oct 15, 2017
Member
|
We do not have good test coverage on the UI interaction (which is why they bug slipped in!) because GUI testing is just hard to begin with and due to difficulty in managing multiple GUI frameworks in the test process. I am 👍 on this without a test |
tacaswell
added
the
Release critical
Contributor
|
Thanks! |
![MeeseeksDev[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
Contributor
|
I have a PR in preparation (well, mostly just waiting for the current backlog to clear...) to add pyflakes testing, which should be able to catch this kind of things. |
dstansby
added a commit
that referenced
this pull request
Oct 16, 2017
Backport PR #9410 on branch v2.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9407
PR Summary
This fixes a bug in #9407 that the line defining
startpathwas mistakenyl removed in the gtk backend, causing users to be unable to save figures. Compare this line to line 567 in backend_gtk3.py (link) which correctly kept the definition.As far as I understand the desired logic is that the startpath rc param is only overwritten if the user didn't explicitly set it to an empty string, which would signify to always use the current dir.
I don't have experience writing unit tests for gui behavior.. If you would like one, could you point me to where this would go?