Skip to content

[Doc] Add pcolor, contour, imshow to and other small changes - #9394

Merged
NelleV merged 1 commit into
matplotlib:masterfrom
jklymak:addpcolor3
Oct 14, 2017
Merged

NelleV merged 1 commit into
matplotlib:masterfrom
jklymak:addpcolor3

Conversation

@jklymak

@jklymak jklymak commented Oct 13, 2017

Copy link
Copy Markdown
Member

PR Summary

  • Added imshow, pcolor, and contour to ../tutorials/introductory/sample_plots.py
  • Changed command to function
  • Removed Demo from many of the titles.

Redo of #9387 (sorry @anntzer, who already commented)

PR Checklist

  • Documentation is sphinx and numpydoc compliant

@afvincent afvincent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment after looking quickly to the PR. I know that something like

My title
===================

is valid RST, but it may be more pleasant to the eyes of most people to use

My title
========

:)

Comment thread tutorials/introductory/sample_plots.py Outdated

Path demo
Paths
=========

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the current version is valid RST, but would it be possible to match the length of the '====' line with the line beyond?

Comment thread tutorials/introductory/sample_plots.py Outdated

Table demo
Tables
==========

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before, but would it be possible to match the length of the '====' line with the line beyond?

Comment thread tutorials/introductory/sample_plots.py Outdated

EEG demo
EEG GUI
=========

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before: would it be possible to match the length of the '====' line with the line beyond?

======

Matplotlib can display images (assuming equal-spaced, equal-aspect-ratio
horizontal dimensions) using the :func:`~matplotlib.pyplot.imshow` function.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. you don't actually need equal aspect ratio
  2. something seems to be missing before or after "horizontal dimensions"?

@NelleV
NelleV merged commit b7b7ad1 into matplotlib:master Oct 14, 2017
@NelleV

NelleV commented Oct 14, 2017

Copy link
Copy Markdown
Member

Thanks a lot @jklymak !

@tacaswell tacaswell added this to the 2.1.0-docs milestone Oct 15, 2017
@tacaswell

Copy link
Copy Markdown
Member

@meeseeksdev backport to v2.1.0-doc

lumberbot-app Bot pushed a commit that referenced this pull request Oct 15, 2017
tacaswell added a commit that referenced this pull request Oct 15, 2017
@jklymak
jklymak deleted the addpcolor3 branch March 5, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants