Skip to content

Don't pass mixed str/bytes inputs to subprocess. - #9393

Closed
anntzer wants to merge 1 commit into
matplotlib:masterfrom
anntzer:fix-9390
Closed

anntzer wants to merge 1 commit into
matplotlib:masterfrom
anntzer:fix-9390

Conversation

@anntzer

@anntzer anntzer commented Oct 13, 2017

Copy link
Copy Markdown
Contributor

Windows+Py3 (specifically, subprocess.list2cmdline) can't handle a
mixture of str and bytes passed as args to subprocess.Popen.

Probably fixes #9390...

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Windows+Py3 (specifically, subprocess.list2cmdline) can't handle a
mixture of str and bytes passed as args to subprocess.Popen.
@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Oct 13, 2017
@anntzer anntzer added this to the 2.1.1 (next bug fix release) milestone Oct 13, 2017
@cgohlke

cgohlke commented Oct 14, 2017

Copy link
Copy Markdown
Contributor

Duplicate of #9292?

@anntzer

anntzer commented Oct 14, 2017

Copy link
Copy Markdown
Contributor Author

... indeed.

@anntzer anntzer closed this Oct 14, 2017
@anntzer
anntzer deleted the fix-9390 branch October 14, 2017 17:37
@anntzer anntzer added status: duplicate and removed Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labels Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Save to .pdf doesn't work in 2.1.0

2 participants