Skip to content

Add tutorials to the Users Guide. - #9381

Merged
tacaswell merged 2 commits into
matplotlib:masterfrom
jklymak:frontdocs
Oct 12, 2017
Merged

tacaswell merged 2 commits into
matplotlib:masterfrom
jklymak:frontdocs

Conversation

@jklymak

@jklymak jklymak commented Oct 12, 2017 •

Copy link
Copy Markdown
Member

PR Summary

Adds tutorials to the user guide.

Addresses #9349 issue of nothing in users guide any more.

Note the heading level for all the tutorial/*/Readme.txt was lowered.

ping @choldgraf

Users Guide

user s_guide_ _matplotlib_2_1_0rc1_post144_dev0_g5645f24e5_documentation

Docs overview

overview_ _matplotlib_2_1_0rc1_post144_dev0_g5645f24e5_documentation

PR Checklist

  • Documentation is sphinx and numpydoc compliant

@choldgraf

Copy link
Copy Markdown
Contributor

ah that's a nice solution! Can you clarify what the two images are? Are those two different pages in the docs?

@jklymak

jklymak commented Oct 12, 2017

Copy link
Copy Markdown
Member Author

Upper image is the Users Guide and the lower image is the docs overview. (links here are to current documentation)

@choldgraf

Copy link
Copy Markdown
Contributor

gotcha - well I am +1 on this and would be in favor of backporting as well

@choldgraf

Copy link
Copy Markdown
Contributor

@tacaswell maybe we can try out our meeseecks friend on this?

@jklymak jklymak added this to the 2.1.0-docs milestone Oct 12, 2017
@tacaswell

Copy link
Copy Markdown
Member

Yes, lets see if it works for other branches!

@tacaswell
tacaswell merged commit 2f63513 into matplotlib:master Oct 12, 2017
@tacaswell

Copy link
Copy Markdown
Member

@meeseeksdev backport to v2.1.0-docs

@jklymak
jklymak deleted the frontdocs branch October 12, 2017 20:23
@choldgraf

Copy link
Copy Markdown
Contributor

@Carreau look we're using it!

@choldgraf

Copy link
Copy Markdown
Contributor

@meeseeksdev say oooooohhhh eeeee!

@lumberbot-app

lumberbot-app Bot commented Oct 12, 2017

Copy link
Copy Markdown

oooooohhhh eeeee!

@choldgraf

Copy link
Copy Markdown
Contributor

@meeseeksdev backport to v2.1.0-doc

@choldgraf

Copy link
Copy Markdown
Contributor

@meeseeksdev say ooooeeeee @tacaswell , you gave the wrong branch name!

@lumberbot-app

lumberbot-app Bot commented Oct 12, 2017

Copy link
Copy Markdown

ooooeeeee @tacaswell , you gave the wrong branch name!

tacaswell added a commit that referenced this pull request Oct 12, 2017
@QuLogic

QuLogic commented Oct 15, 2017

Copy link
Copy Markdown
Member

@tacaswell speaking of wrong branch names, did @meeseeksdev not backport because the branch and milestone are not the same name?

@tacaswell

Copy link
Copy Markdown
Member

No, it was just because I flubbed the typing, but I think I will change the milestone to match the branch name.

@QuLogic

QuLogic commented Oct 15, 2017 •

Copy link
Copy Markdown
Member

No, I meant why it didn't do it automatically (because the milestone was set before the PR was merged.)

@tacaswell

Copy link
Copy Markdown
Member

The automatic backport is controlled by the on-merge: backport to v2.1.0-doc line in the description of the milestone (which I added after this PR was merged) (see https://github.com/matplotlib/matplotlib/milestones )

I only know how this works because @Carreau was sitting next to me and pointed me to where I needed to edit for the v2.1.1 milestone.

@Carreau

Carreau commented Oct 15, 2017

Copy link
Copy Markdown
Contributor

I only know how this works because @Carreau was sitting next to me and pointed me to where I needed to edit for the v2.1.1 milestone.

Yeah, I implemented that about 48h before showing it to @tacaswell and need to document it.
I also need to add better error handling when the branch name is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants